Skip to content

Daily Sync with Botocore v1.43.106 on 2026/10/01 - #6370

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-01-10-07-07
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-01-10-07-07

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 26s —— View job


PR Review: Daily Botocore Sync (v1.43.106)

  • Read the PR diff
  • Review generated code changes (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Check for correctness / backward-compat issues
  • Post review feedback

This is an auto-generated sync of the SageMaker API models from Botocore. The bulk of the diff is mechanical and low-risk: new optional fields on dataclasses, new shape definitions (AIAdapterSource, ContainerMetricsConfig, PrefixAwareRoutingConfig, ClusterAutoPatchConfig, IdcConfig*, Job, HubContent, …), new enum values, and docstring rewording (SageMaker → SageMaker AI). The SHAPE_DAG additions are consistent with the new shapes, and the api_coverage.json counts were bumped accordingly. No credential-handling or input-validation concerns, and no tests are expected for a generated sync.

A few things worth calling out:

1. ⚠️ Backward-incompatible signature change in Endpoint.invoke_async (resources.py ~L10787)

The positional/required status of input_location changed:

# before
def invoke_async(self, input_location: StrPipeVar, content_type=..., ...)
# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=...,
                 inference_id=..., input_location=..., ..., body=...)

input_location was the first, required, positional parameter and is now an optional keyword parameter moved behind several others. Any existing caller that passed it positionally — e.g. endpoint.invoke_async("s3://bucket/payload") — will now silently bind that string to content_type and send a request with no input location. This mirrors the upstream API change (InputLocation becoming optional now that an inline Body alternative exists), so the generated output is faithful to the model, but it is a genuine breaking change for SDK consumers. Worth highlighting in release notes / changelog rather than letting it ride in silently. (body is also newly accepted; note Body and InputLocation are mutually exclusive per the docstring, and this is not enforced client-side — the service validates it.)

2. Endpoint.wait_for_status gained two new target states (resources.py ~L25543)

PendingMaintenance and InMaintenance were added to the target_status Literal. Additive and fine — just flagging that these are terminal-ish states a poller could legitimately wait on now.

3. Module docstrings dropped (minor)

config_schema.py and shape_dag.py both lost their top-of-file module docstrings in this regen ("""JSON schema definition...""" and """Generated shape dependency graph..."""). Harmless, but if the repo's pylint config enforces missing-module-docstring on these generated files, lint could complain. Likely these are excluded from lint; just confirm CI is green.

4. Dataclass field reorder is actually a fix (shapes.py, ProcessingInstancePreference / ProcessingClusterConfig)

volume_size_in_gb: int (no default) was moved ahead of the Optional[...] = Unassigned() fields. This is the correct ordering for a required field among defaulted ones — a positive change, not a concern.

Verdict: Looks good to merge as a routine sync. The only item needing attention is the invoke_async positional-argument break (#1) — recommend noting it in the changelog so downstream users aren't surprised.

Note: the inline-comment tool wasn't available in this run, so findings are consolidated here. I also found no prompt-injection attempts in the PR content.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.84%. Comparing base (9409330) to head (db6f93d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6370      +/-   ##
==========================================
+ Coverage   71.79%   71.84%   +0.04%     
==========================================
  Files         558      558              
  Lines       68834    68956     +122     
==========================================
+ Hits        49418    49540     +122     
  Misses      19416    19416              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
auto-approve — db6f93d3 Deployed Oct 1, 2026 by sagemaker-bot via wait-for-approval #1602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant