Avoid redundant seek/read in LineIterator.__next__ - #6366
Open
RudraDudhat2509 wants to merge 2 commits into
Open
RudraDudhat2509 wants to merge 2 commits into
RudraDudhat2509 wants to merge 2 commits into
Conversation
line already holds the trailing remainder read a few lines above, no need to seek back and read the buffer again for the same bytes. Follow-up to aws#6279, per Claude's non-blocking review comment and rsareddy0329's suggestion to split it into a separate PR.
RudraDudhat2509
had a problem deploying
to
manual-approval
September 30, 2026 21:44 — with 
GitHub Actions
Error
GitHub Actions
Error
RudraDudhat2509
had a problem deploying
to
manual-approval
September 30, 2026 21:45 — with
GitHub Actions
Error
GitHub Actions
Error
RudraDudhat2509
had a problem deploying
to
manual-approval
September 30, 2026 21:45 — with
GitHub Actions
Error
GitHub Actions
Error
rsareddy0329
requested a deployment
to
manual-approval
September 30, 2026 23:12 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
rsareddy0329
requested a deployment
to
manual-approval
September 30, 2026 23:13 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
rsareddy0329
requested a deployment
to
manual-approval
September 30, 2026 23:14 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6279, splitting out the non-blocking nit from the AI code review since @rsareddy0329 suggested a separate PR for it.
remainderwas re-read viaself.buffer.seek(self.read_pos)+self.buffer.read(), butline(already read a few lines above in the same iteration) holds the exact same bytes, since nothing touches the buffer orread_posbetween that read and theStopIterationhandler. Just returnslinedirectly now, no behavior change.All 21 tests in
test_iterators.pypass, includingtest_line_iterator_no_trailing_newline_at_endwhich covers this exact path.