Repository navigation
Conversation
Layer: 2-client-log-rate-limit
Collaborator
Author
|
Dropping the rate limiter: the 10,000-character cap already bounds each entry, and Graph Explorer is the only caller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anyone who can reach the proxy can write to the log, so
/loggerneeds a bound on how fast entries arrive.User-facing: none
createRateLimiteris a small fixed-window limiter inrate-limiter.ts, one per app.Evidence
Before: no limit on request volume.
After: the 301st request in a window gets a 429 and writes no log entry at any level. The window rolls over at exactly 60 seconds, and rejected form posts don't use up the budget.
Merge Danger
Door: two-way
Impact: consumers
A caller sending more than 300 log requests in a minute gets 429s.
Related