Repository navigation
fix(integ-runner): region not passed when deploying tests - #2131
Conversation
The current version of the integ-runner does not pass the `CDK_DEFAULT_ACCOUNT` and `CDK_DEFAULT_REGION` environment variables to the app that's being tested if it is being deployed. This means that any feature that relies on the region being available, like lookups, doesn't work. Also tests that rely on `stack.accountId` and `stack.region` being resolved values (like the `ProductStack` tests) fail. Make sure the region gets resolved when we are synthesizing for deployments.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Automated review A maintainer will still review this — treat the notes below as a starting point. 📌 Commit This PR fixes a bug in the integ-runner where The change is small, internally consistent, and test-backed: the new required 🔴 0 blocking · 🟡 0 recommended · ⚪ 0 optional Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 82 82
Lines 13195 13195
Branches 1894 1895 +1
=======================================
Hits 12146 12146
Misses 1011 1011
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The current version of the integ-runner does not pass the
CDK_DEFAULT_ACCOUNTandCDK_DEFAULT_REGIONenvironment variables to the app that's being tested if it is being deployed.This means that any feature that relies on the region being available, like lookups, doesn't work. Also tests that rely on
stack.accountIdandstack.regionbeing resolved values (like theProductStacktests) fail.Make sure the region gets resolved when we are synthesizing for deployments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license