Repository navigation
Conversation
…tigate-failures When a deployment fails, cdk deploy investigates beyond the CloudFormation error using the lookup role: CloudTrail control-plane errors, custom resource Lambda logs and ECS stopped tasks. Add an investigateFailures deploy option (toolkit-lib) and --investigate-failures flag / cdk.json setting (CLI) to turn this off. The CloudFormation error is always reported, and cdk diagnose is unaffected. Defaults to on.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Automated review A maintainer will still review this — treat the notes below as a starting point. 📌 Commit This PR adds a 🔴 0 blocking · 🟡 0 recommended · ⚪ 0 optional Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
+ Coverage 92.07% 92.20% +0.12%
==========================================
Files 82 83 +1
Lines 13206 13283 +77
Branches 1900 1912 +12
==========================================
+ Hits 12160 12247 +87
+ Misses 1008 998 -10
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…th --investigate-cloudtrail CloudTrail events cannot be tied to a specific deployment, and delivery can lag up to 15 minutes behind the failure, so at deploy time the lookup is often incomplete or unrelated. cdk deploy no longer performs it by default; pass --investigate-cloudtrail (or set investigateCloudTrail in cdk.json) to include it. cdk diagnose always performs it. Replaces the investigateFailures option: custom resource Lambda log and ECS stopped-task lookups keep running on deploy as before.
There was a problem hiding this comment.
See the review summary comment for the overview; the notes below are inline.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
See the review summary comment for the overview; the notes below are inline.
Fixes #2084
Description
When a deployment fails,
cdk deploycan investigate beyond the CloudFormation error using multiple methods:Changes
Each of these methods require additional API calls beyond what CloudFormation resource handlers return. This change creates a consolidated interface behind the
--investigateflag, which takes comma-separated strings:It also disables CloudTrail logs by default.
Run
cdk deploywith the new flag:# example that enables CloudTrail but disables ECS container logs cdk deploy MyStack --investigate cloudtrail,no-ecsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license