Repository navigation
Fix Windows CI: rename nul.txt test fixture - #9
Merged
Merged
Conversation
On the windows-2022 runner nul.txt is the NUL device, so writing the fixture went nowhere and reading it back failed with an io error instead of reaching the not-a-text-file check. Co-authored-by: awakenginexe <267649137+awakenginexe@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge of #8 failed `Host tests` on main: `desktop::tests::the_editor_refuses_what_is_not_an_editable_text_file` got `io` instead of `not-text`.
On the Windows runner `nul.txt` is the NUL device, so the fixture was never written and reading it back failed with an io error. The fixture is renamed to `zero-byte.txt`. Test-only change; no app code touched.
Passes locally (`cargo test --lib desktop::tests`, 9/9).
🤖 Generated with Claude Code