Repository navigation
release: Awake Modpack Manager 1.3.3 - #11
Merged
Merged
Conversation
Checking a plan with a CurseForge mod whose author turned off third-party distribution used to stop at "CurseForge project does not allow third-party distribution". The Review page now lists those mods with a button that opens the file's CurseForge download page, an "Open all" button when there are several, and a file picker. While the page waits, the host looks in the Downloads folder and moves the jar whose SHA-1 is the one CurseForge lists into the project's mods folder, then the install leaves the draft. Nothing in mods is overwritten. The helper cannot accept a local file, so the mod shows as a manually added file.
An apply was rolled back with "Applied metadata did not verify" when any tracked mod's jar no longer matched the helper's record, even a mod the change did not touch. Review & apply now lists those mods before applying, with Restore originals (hash-checked re-download, changed file backed up to policy-backups) or Keep my files (drop the record, keep the file as an untracked mod). The host side is fix_modified in desktop.rs. History now lists the newest operation first and shows which mods each apply installed, removed, updated, enabled or disabled. The helper keeps no mod names, so the Manager records the reviewed plan's items by operation id in local storage (newest 200 applies).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
mainup to 1.3.3. It also includes 1.3.2 (cd48702), which was tagged and released fromrelease/1.3.2but never merged.1.3.3
fix_modifiedinsrc-tauri/src/desktop.rs.Release notes:
docs/releases/v1.3.3.md.Checks
npm run typecheck: passesnpm test: 219 passedcargo test --lib: the newfix_modifiedtest passes.profile_access::matches_the_launcher_rule_and_fixes_folders_others_can_writefails on the dev machine with or without this change, so it depends on that machine's folder permissions. CI shows the clean-runner result.🤖 Generated with Claude Code