feat(react-kratos): upgrade Kratos client - #160
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87e8a6858f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db2bdd23d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d01621248
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c091537 to
bc486c0
Compare
1 participant
Task
How to verify
Main scenario
Context: an application using Ory Kratos native self-service flows.
Action: create a
FrontendApiwith@ory/kratos-client-fetch@26.2.0, provide it throughSdkProvider, and renderLoginNativeFloworRegistrationNativeFlow.Expected result: the package uses the provided SDK without Axios, does not re-export the vendor API, and preserves its public flow components, hooks, and providers.
Context: submitting a login or registration flow.
Action: verify a validation response,
404,410withuse_flow_id, redirect, reauthentication, and an unknown SDK error.Expected result: validation updates the flow; a missing or expired flow restarts; a failure to create a fresh flow or load a replacement flow invokes
onErrorand rejects the submit promise; reading the error body in the submit callback does not prevent further flow handling; redirects are passed to the platform adapter; other vendor errors are not masked.Context: a consumer of
@atls/react-kratos.Action: import vendor types directly from
@ory/kratos-client-fetchand build the package.Expected result: the ESM exports and TypeScript declarations build successfully, and the former
export * from '@ory/client'is absent.Additional scenario
Context: the repository root at head
bc486c0b1530fd840ba7665f11176bdedc43bd71.Action: run
corepack yarn test unit --test-reporter tap.Expected result: all 10 project-owned unit tests pass.
Context: GitHub PR feat(react-kratos): upgrade Kratos client #160 after the history rewrite.
Action: inspect current-head CI and Codex review state.
Expected result:
Checks / Checks,Lint,TypeCheck,Test:Unit,Test:Integration, and the CI jobReleasecomplete successfully, and the Codex review cycle completes for the exact current head. The CI job namedReleasedoes not mean that an npm package was published.Proofs
corepack yarn test unit --test-reporter tap— 10/10;@atls/react-kratosbuild — 36 files; commit hooks completed successfully.