Repository navigation
Fix/amd session resume link v2 - #4
Merged
Merged
Conversation
- SessionResolver adopts a `?amd_session=<uuid>` resume link, restores the stored journey (intake answers included) and re-issues the cookie. - A freshly minted session now inserts its row, so its first-touch attribution and `reconciled` flag are stored, and records `session_created` with its source category. - Attribution: canonical tracking keys and vendor aliases (AttributionNormalizer), derived source/device/browser/OS (DerivedAttribution), and `_amd` payload decryption with key rotation (AmdPayload, keys from AMD_TRACKING_KEY / AMD_TRACKING_KEY_PREVIOUS). - Cookie branch reads an unreconciled journey against the EMR once and re-mints a session the EMR no longer recognises, carrying the journey. - /health reports whether the tracking keys are configured (presence only).
It holds only the CSRF token and short-lived counters, and MemoryStore already drops every session on restart, so the rename logs nobody out. Journey state stays under the separate amd_session cookie.
CI runs type-check, lint, tests, build, the asset build and config:validate on Node 22 and 24. config/channel.generated.ts is gitignored, so a fresh clone could not compile; the example file gives it an empty shape to copy.
The factory declared an unused nullReporter parameter that its inject list did not, so every later argument shifted by one and instrumentation received the verification gateway. GET /checkout/ answered 500.
Drop the porting-plan phase labels and PHP/Kysely history from code comments, docs and test descriptions so they describe the Node storefront as it is. - Strip "(Phase N)" labels and "Phase N's done bar" wording from src, config, prisma schema, views and test files; rewrite the phase-ordered JourneyState doc comment as a per-subsystem list. - Replace PHP-isms in comments (PDO driver note, array_keys($payload)) with their Node equivalents or remove them. - Drop references to the earlier Kysely persistence layer and the porting plan's "Corrections found during implementation" notes. - Remove the storefront-lamp link from docs/STACK.md. - Reword "this port" comments in intake-upload.controller.ts and reverse-reconciliation.ts to describe current behaviour. Comment and test-title changes only; no runtime behaviour changes.
saburali-codeclouds
force-pushed
the
fix/amd-session-resume-link-v2
branch
from
November 17, 2026 07:38
3c4a3be to
eed46ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three review points.
?amd_session=link: the code now restores the visitor's answers, as the README says.amd_php_sessionrenamed toamd_sid. Nobody is logged out, because it only holds the CSRF token.STATUS.md: deleted, along with every link to it._amdlinks supported, and stale sessions replaced.Remove LAMP-port references from comments