Repository navigation
Propagate lazy query errors through jq JSON conversion - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a lazy query fails while
tojson,@json, orformat("json")materializes rows, the embedded jq encoder previously panicked instead of returning the Spanner error.Add small jq definitions that normalize lazy values before JSON encoding and return the original error through jq's normal error path, including
try/catch. Keep gojq's JSON number/string formatting, other format operations, and user-defined function overrides. No dependency fork, replacement, or panic recovery is introduced.Validation: Go 1.25.13 build, full emulator-backed tests, and lint; CLI regressions for original error codes/messages and catch behavior; 100 independent differential checks against the unchanged jq engine for healthy values and format/function combinations. The four independent fixes were also validated together.