Repository navigation
Launch Windows gcloud batch wrappers through cmd.exe - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the Cloud SDK normally provides
gcloud.cmd, which cannot be launched directly with CreateProcess. Route.cmdand.batfiles throughcmd.exe /d /s /cusing an explicit command line; keep executable files on the direct launch path.Add a fake batch-file regression in a directory containing spaces and a focused Windows CI job. The test verifies the login arguments without contacting Google or using credentials. Correct the prior comment claiming Windows automatically starts an interpreter.
Validation: Go 1.25.13 build, full emulator-backed tests and lint on macOS; independent quoting regression and Windows cross-compilation. Native Windows execution is covered by the new CI job and must pass before merge.