Repository navigation
Preserve primary output when lazy SQL draining fails - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy jq filters such as
first(.rows[])can finish before the SQL stream does. With split plan output, a later SQL error previously replaced an existing primary output file with partial results.Mark the primary output complete only after the required SQL drain succeeds. Preserve publication when SQL succeeds but subsequent plan rendering fails. Regression tests exercise both cases through the real Spanner client and a local gRPC fixture with a resume token.
Validation: Go 1.25.13 build, full tests with the Spanner emulator, and golangci-lint; independent regression verification.