Skip to content

Add CI: run the verification loop on PRs and main - #14

Merged
maxsoldev merged 2 commits into
mainfrom
add-ci-workflow
Oct 9, 2026
Merged

maxsoldev merged 2 commits into
mainfrom
add-ci-workflow

Conversation

@maxsoldev

Copy link
Copy Markdown
Collaborator

There was no CI in this repo, so every check was manual and nothing stopped a broken build from reaching main. This adds one workflow running the loop CLAUDE.md already documents.

What runs

Step Command
Build (frontend + Go) task build
Lint frontend task lint
Vet go vet ./...
Test task test
Shell syntax bash -n over every deploy/*.sh

Triggers on pull_request and pushes to main, with concurrency cancelling superseded PR runs and permissions: contents: read.

Two deliberate choices

It drives Task instead of reimplementing the build. task build is what copies web/dist into cmd/appx/web/dist, and go build ./... cannot run before that because of go:embed — so a hand-rolled CI script would have to duplicate that ordering and could drift from the Taskfile. Task is installed with go install ...@v3.54.0 (pinned), which keeps the workflow on first-party actions only rather than pulling in a third-party setup action.

No gofmt gate. gofmt -l currently flags a dozen pre-existing files:

$ gofmt -l . | grep -v node_modules
agentversion.go
internal/auth/store.go
internal/server/agent_proxy.go
...

All of it is doc-comment list indentation from a different gofmt version:

-//	1. edit AGENT_VERSION
+//  1. edit AGENT_VERSION

Gating on it would fail on the first run, and fixing it would churn files unrelated to any change in flight. Better as its own commit. go vet is gated — it's clean today.

Drive-by fix

task test ran only ./internal/..., so anything under cmd/ was invisible to both local runs and CI. Extended to ./internal/... ./cmd/.... On main that reports cmd/appx [no test files]; #10 adds the first tests there, which would otherwise never have run.

Verification

Every step run locally against main before pushing — task build, task lint, go vet ./..., task test, and the bash -n loop all pass. The workflow also validates itself on this PR, since GitHub runs a PR's own workflow file.

Once this merges I'll refresh #10, #11, #12 and #13 so they each get a CI run before merging.

🤖 Generated with Claude Code

maxsoldev and others added 2 commits October 9, 2026 11:39
There was no CI, so every check was manual and nothing stopped a broken
build from reaching main.

The workflow runs the loop CLAUDE.md already documents — task build, task
lint, task test — plus go vet and a bash -n parse of every deploy script.
It drives Task rather than reimplementing the build so CI and local cannot
drift: `task build` is what copies web/dist into cmd/appx/web/dist, and
`go build ./...` cannot run before that because of go:embed. Task is
installed via `go install` at a pinned version, keeping the workflow on
first-party actions only.

Also extends `task test` to ./cmd/... — it only ran ./internal/..., so
entry-point tests would have been invisible to both local runs and CI.

Deliberately NOT gating on gofmt: `gofmt -l` currently flags a dozen
pre-existing files, all of them doc-comment list indentation from a
different gofmt version, so the gate would fail on its first run and the
fix would churn files unrelated to any change in flight. Worth doing as its
own commit.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
setup-go exports GOTOOLCHAIN=local, so `go install task@v3.54.0` failed:
that release requires go 1.26.4 and go.mod pins 1.26.1. v3.53.1 requires
1.25.10, which the repo's toolchain satisfies without downloading another one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@maxsoldev
maxsoldev merged commit 0f37256 into main Oct 9, 2026
1 check passed
@maxsoldev
maxsoldev deleted the add-ci-workflow branch October 9, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant