Repository navigation
Add CI: run the verification loop on PRs and main - #14
Merged
Merged
Conversation
There was no CI, so every check was manual and nothing stopped a broken build from reaching main. The workflow runs the loop CLAUDE.md already documents — task build, task lint, task test — plus go vet and a bash -n parse of every deploy script. It drives Task rather than reimplementing the build so CI and local cannot drift: `task build` is what copies web/dist into cmd/appx/web/dist, and `go build ./...` cannot run before that because of go:embed. Task is installed via `go install` at a pinned version, keeping the workflow on first-party actions only. Also extends `task test` to ./cmd/... — it only ran ./internal/..., so entry-point tests would have been invisible to both local runs and CI. Deliberately NOT gating on gofmt: `gofmt -l` currently flags a dozen pre-existing files, all of them doc-comment list indentation from a different gofmt version, so the gate would fail on its first run and the fix would churn files unrelated to any change in flight. Worth doing as its own commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
setup-go exports GOTOOLCHAIN=local, so `go install task@v3.54.0` failed: that release requires go 1.26.4 and go.mod pins 1.26.1. v3.53.1 requires 1.25.10, which the repo's toolchain satisfies without downloading another one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no CI in this repo, so every check was manual and nothing stopped a broken build from reaching
main. This adds one workflow running the loopCLAUDE.mdalready documents.What runs
task buildtask lintgo vet ./...task testbash -nover everydeploy/*.shTriggers on
pull_requestand pushes tomain, withconcurrencycancelling superseded PR runs andpermissions: contents: read.Two deliberate choices
It drives Task instead of reimplementing the build.
task buildis what copiesweb/distintocmd/appx/web/dist, andgo build ./...cannot run before that because ofgo:embed— so a hand-rolled CI script would have to duplicate that ordering and could drift from the Taskfile. Task is installed withgo install ...@v3.54.0(pinned), which keeps the workflow on first-party actions only rather than pulling in a third-party setup action.No
gofmtgate.gofmt -lcurrently flags a dozen pre-existing files:All of it is doc-comment list indentation from a different gofmt version:
Gating on it would fail on the first run, and fixing it would churn files unrelated to any change in flight. Better as its own commit.
go vetis gated — it's clean today.Drive-by fix
task testran only./internal/..., so anything undercmd/was invisible to both local runs and CI. Extended to./internal/... ./cmd/.... Onmainthat reportscmd/appx [no test files]; #10 adds the first tests there, which would otherwise never have run.Verification
Every step run locally against
mainbefore pushing —task build,task lint,go vet ./...,task test, and thebash -nloop all pass. The workflow also validates itself on this PR, since GitHub runs a PR's own workflow file.Once this merges I'll refresh #10, #11, #12 and #13 so they each get a CI run before merging.
🤖 Generated with Claude Code