RATIS-2716. The string based ip address should be normalized in SetPriorityCommand - #1610
Merged
Merged
Conversation
szetszwo
reviewed
Sep 25, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
@amaliujia , thanks for working on this! Please see the comments inlined.
| for (String optionValue : optionValues) { | ||
| String[] str = optionValue.split("[|]"); | ||
| if (str.length < 2) { | ||
| throw new IllegalArgumentException("The format of the parameter is wrong"); |
Contributor
There was a problem hiding this comment.
Let's add the format and the actual value in the message:
throw new IllegalArgumentException("Invalid option <PEER_HOST:PEER_PORT|PRIORITY>: " + optionValue);| addressPriorityMap = parseAddressPriorityMap( | ||
| cl.getOptionValues(PEER_WITH_NEW_PRIORITY_OPTION_NAME)); | ||
| } catch (IllegalArgumentException e) { | ||
| println("The format of the parameter is wrong"); |
Contributor
There was a problem hiding this comment.
Let's print out the exception:
e.printStackTrace(getPrintStream());
szetszwo
approved these changes
Sep 25, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The string based ip address should be normalized in SetPriorityCommand. For example,
localhost:5won't be able to match with127.0.0.1.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2716
How was this patch tested?
Unit test