Skip to content

Release messageRouter persistent reference in ProducerConfig destructor (per-producer GC leak) #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amit-motorq wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

Release messageRouter persistent reference in ProducerConfig destructor (per-producer GC leak) #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ProducerConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,14 @@ ProducerConfig::ProducerConfig(const Napi::Object& producerConfig) : topic("") {
}
}

ProducerConfig::~ProducerConfig() {}
ProducerConfig::~ProducerConfig() {
// Release the persistent reference to the JS messageRouter callback. Without
// this, every producer created with a custom messageRouter pins the callback
// (and everything its closure captures) as a GC root for the lifetime of the
// process, long after the producer and its client are closed, leaking memory
// per closed producer. Reset() is a no-op when no router was configured.
messageRouter.Reset();
}

std::shared_ptr<pulsar_producer_configuration_t> ProducerConfig::GetCProducerConfig() {
return this->cProducerConfig;
Expand Down