GH-3672: Isolate Avro usage in parquet-cli - #3812
Open
makarandhinge wants to merge 2 commits into
Open
makarandhinge wants to merge 2 commits into
makarandhinge wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3672
Rationale for this change
The Parquet-native
cat,head, andscanpaths were unnecessarily going through Avro schema conversion. This could cause valid Parquet files containing INT96 fields or nested LIST structures to fail during schema conversion.What changes are included in this PR?
This PR isolates Avro usage from the Parquet-native data-reading paths.
GroupReadSupportand read theMessageTypedirectly from the Parquet footer.cat,head, andscanuse the native Parquet reader for Parquet input.Are these changes tested?
Yes. Regression tests were added for the affected Parquet CLI paths, including INT96, nested LIST structures, column projection, and multi-file scanning.
Are there any user-facing changes?
This is a bug fix for the Parquet data-reading path. Valid Parquet files that previously failed because of unnecessary Avro schema conversion can now be processed through the native Parquet reader.
The remaining Avro isolation work will be added to this PR later.