Skip to content

DIRMINA-1030 - MdcInjectionFilterTest - allow only selected filter names to be processed - #73

Open
the-thing wants to merge 1 commit into
apache:2.2.Xfrom
the-thing:dirmina-1030-mdc-injection-filter-test
Open

the-thing wants to merge 1 commit into
apache:2.2.Xfrom
the-thing:dirmina-1030-mdc-injection-filter-test

Conversation

@the-thing

Copy link
Copy Markdown
Member

Fix for DIRMINA-1030. Follow up after #68 missed another log event sneaking in action https://github.com/apache/mina/actions/runs/36304640299/job/108578715693

Instead of skipping certain logger names lets just allowed specific ones for other events not to leak - similar to this test case

Events picked up during the test run:

org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_CREATED event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_CREATED event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionCreated
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionCreated
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_CREATED has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_CREATED has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_OPENED event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_OPENED event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / DummyIoFilter.sessionOpened
org.apache.mina.filter.logging.MdcInjectionFilterTest / DummyIoFilter.sessionOpened
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionOpened
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionOpened
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_OPENED has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_OPENED has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a MESSAGE_RECEIVED event for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a MESSAGE_RECEIVED event for session 4
org.apache.mina.filter.codec.ProtocolCodecFilter / Processing a MESSAGE_RECEIVED for session 1
org.apache.mina.filter.codec.ProtocolCodecFilter / Processing a MESSAGE_RECEIVED for session 4
org.apache.mina.filter.logging.MdcInjectionFilterTest / decode
org.apache.mina.filter.logging.MdcInjectionFilterTest / decode
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageReceived-1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageReceived-1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageReceived-2
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageReceived-2
org.apache.mina.filter.logging.MdcInjectionFilterTest / encode
org.apache.mina.filter.logging.MdcInjectionFilterTest / encode
org.apache.mina.core.filterchain.IoFilterEvent / Firing a WRITE event for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a WRITE event for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Event WRITE has been fired for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / encode
org.apache.mina.core.filterchain.IoFilterEvent / Event WRITE has been fired for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / encode
org.apache.mina.core.filterchain.IoFilterEvent / Firing a WRITE event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a WRITE event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event WRITE has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event WRITE has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a EXCEPTION_CAUGHT event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a EXCEPTION_CAUGHT event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / exceptionCaught
org.apache.mina.filter.logging.MdcInjectionFilterTest / exceptionCaught
org.apache.mina.core.filterchain.IoFilterEvent / Event EXCEPTION_CAUGHT has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event MESSAGE_RECEIVED has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event EXCEPTION_CAUGHT has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Event MESSAGE_RECEIVED has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a MESSAGE_SENT event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a MESSAGE_SENT event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-2
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-2
org.apache.mina.core.filterchain.IoFilterEvent / Event MESSAGE_SENT has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event MESSAGE_SENT has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a MESSAGE_SENT event for session 4
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-2
org.apache.mina.core.filterchain.IoFilterEvent / Event MESSAGE_SENT has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a MESSAGE_SENT event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-1
org.apache.mina.filter.logging.MdcInjectionFilterTest / messageSent-2
org.apache.mina.core.filterchain.IoFilterEvent / Event MESSAGE_SENT has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_IDLE event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_IDLE event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionIdle
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionIdle
org.apache.mina.core.filterchain.IoFilterEvent / Firing a CLOSE event for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a CLOSE event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event CLOSE has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event CLOSE has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_IDLE has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_IDLE has been fired for session 1
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_CLOSED event for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Firing a SESSION_CLOSED event for session 1
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionClosed
org.apache.mina.filter.logging.MdcInjectionFilterTest / sessionClosed
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_CLOSED has been fired for session 4
org.apache.mina.core.filterchain.IoFilterEvent / Event SESSION_CLOSED has been fired for session 1

@the-thing the-thing self-assigned this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant