Repository navigation
KNOX-3518: Pin vitest to 4.1.11 to work around npm peer-resolution crash in UI builds - #1458
Merged
Merged
Conversation
…ash in UI builds Since vitest 4.1.12 was published, `npm install` fails in every Angular UI module with "Cannot read properties of null (reading 'edgesOut')". @angular/build declares vitest as an optional peer. vitest 4.1.12 declares the optional peer @vitest/browser-webdriverio ^4.1.11, which only exists as 4.1.11 and requires vitest 4.1.11 exactly. The npm bundled with Node v22.20.0 (10.9.3) crashes on that conflict instead of reporting ERESOLVE. The UI poms delete package-lock.json on clean, so every build hits it. Override vitest to 4.1.11 in all UI modules. None of them uses vitest, so the build output is unchanged; the override can be removed once vitest publishes a consistent release. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3518 - Pin vitest to 4.1.11 to work around npm peer-resolution crash in UI builds
What changes were proposed in this pull request?
Since vitest 4.1.12 was published (2026-10-15),
npm installfails in every Angular UI module withnpm error Cannot read properties of null (reading 'edgesOut'), which breaks the full Maven build.@angular/builddeclares vitest as an optional peer. vitest 4.1.12 declares the optional peer@vitest/browser-webdriverio ^4.1.11, which only exists as 4.1.11 and requires exactlyvitest 4.1.11. The npm bundled with Node v22.20.0 (npm 10.9.3) crashes on this conflict instead of reporting ERESOLVE. The UI poms deletepackage-lock.jsonon clean, so every build hits it.This PR adds
"overrides": { "vitest": "4.1.11" }to gateway-admin-ui, knox-homepage-ui, knox-token-management-ui, knox-token-generation-ui and knox-webshell-ui. None of them uses vitest, so the build output is unchanged. The override can be removed once vitest publishes a consistent release.How was this patch tested?
masterwithnpm install --dry-runon each UI'spackage.json(Node v22.20.0 / npm 10.9.3). All 5 UIs fail without the override and resolve with it.mvn -pl gateway-admin-ui,knox-homepage-ui,knox-token-management-ui,knox-token-generation-ui,knox-webshell-ui clean install -DskipTestspassed.cleanremoves the lockfiles andnode_modules, so dependencies resolved from scratch.Integration Tests
None added. This is a build-dependency pin with no runtime effect.