Skip to content

[To dev/1.3] Fix oversized Load TsFile piece dispatch - #18674

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:backport-18627-dev-1.3
Open

Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:backport-18627-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Backports #18627 to dev/1.3.

This keeps the dev/1.3-specific implementation while adding Thrift frame-size discovery, sender-side slicing, receiver-side validation and assembly, cleanup integration, and tests.

Compatibility notes:

  • dev/1.3 uses raw status strings because the newer compile-time i18n mechanism is not present.
  • The assembler returns a heap ByteBuffer because this branch deserializes through ByteBuffer.array().

Validation:

  • mvn -o -pl iotdb-protocol/thrift-datanode -am generate-sources -DskipTests
  • mvn -o -pl iotdb-core/datanode -DskipTests test-compile
  • mvn -o -pl iotdb-core/datanode -Dtest=DataNodeInternalRPCServiceImplLoadTest,LoadTsFileDispatcherImplTest,LoadTsFilePieceNodeAssemblerTest test (with JDK 17 module opens and -Xmx1g)
  • 15 tests passed, 0 failures, 0 errors

* Fix oversized Load TsFile piece dispatch

* Address Load TsFile slicing review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants