Skip to content

fix(hubble): explain unverified connections before sign-in - #853

Merged
imbajin merged 8 commits into
apache:masterfrom
hugegraph:fix/hubble-login-connection-status-20261025
Oct 27, 2026
Merged

imbajin merged 8 commits into
apache:masterfrom
hugegraph:fix/hubble-login-connection-status-20261025

Conversation

@imbajin

@imbajin imbajin commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

When Hubble cannot confirm Server capabilities, the login page now explains the connection state and offers a retry instead of implying an account problem. The route stays closed until verification completes, recovery preserves entered credentials, and repeated quiet configuration checks—including HTTP and business 429 responses—use inline feedback. Other requests retain their existing throttling notices.

Validation on 98832099: nine focused suites / 122 tests, ESLint, bilingual copy checks, TypeScript and the production build passed. Nine actual Chromium checks passed, including repeated throttling without modal/toast interruptions; eight final screenshots were captured and inspected outside Git. The old CI punctuation failure was corrected in this commit; current-head CI is tracked separately.

Before/after screenshots and the Hubble issue record are available to authorized readers. The task owner explicitly requires screenshots to stay outside Git. Native public GitHub image upload is unavailable in this connection.

Source review: hugegraph#98

Visual overview

Unverified Server connection status before normal sign-in

Unverified Server connections receive inline status and retry guidance before normal sign-in; entered credentials are preserved. Concept diagram, not authentication or security acceptance.

MrJs133
MrJs133 previously approved these changes Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.78%. Comparing base (411aca3) to head (6dba597).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #853      +/-   ##
============================================
+ Coverage     51.79%   53.78%   +1.99%     
+ Complexity     5309     3463    -1846     
============================================
  Files           619      282     -337     
  Lines         31606    19242   -12364     
  Branches       3945     2891    -1054     
============================================
- Hits          16370    10350    -6020     
+ Misses        13750     7789    -5961     
+ Partials       1486     1103     -383     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bitflicker64 bitflicker64 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: no. Score: 9/10. Summary: App.js deduplicates manual and polled /config checks, isAuthEnabled keeps partial unverified probes authenticated, and only the bootstrap /config poll silences throttle warnings; the bundled Vermeer paging, TopBar and Meta scopeRef changes also hold up.

@imbajin
imbajin merged commit 453eed3 into apache:master Oct 27, 2026
21 checks passed
@imbajin
imbajin deleted the fix/hubble-login-connection-status-20261025 branch October 27, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants