Repository navigation
Conversation
MrJs133
previously approved these changes
Oct 25, 2026
added 4 commits
October 25, 2026 16:46
…into fix/hubble-login-connection-status-20261025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #853 +/- ##
============================================
+ Coverage 51.79% 53.78% +1.99%
+ Complexity 5309 3463 -1846
============================================
Files 619 282 -337
Lines 31606 19242 -12364
Branches 3945 2891 -1054
============================================
- Hits 16370 10350 -6020
+ Misses 13750 7789 -5961
+ Partials 1486 1103 -383 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 25, 2026
Closed
Closed
bitflicker64
approved these changes
Oct 26, 2026
bitflicker64
left a comment
Contributor
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: App.js deduplicates manual and polled /config checks, isAuthEnabled keeps partial unverified probes authenticated, and only the bootstrap /config poll silences throttle warnings; the bundled Vermeer paging, TopBar and Meta scopeRef changes also hold up.
MrJs133
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Hubble cannot confirm Server capabilities, the login page now explains the connection state and offers a retry instead of implying an account problem. The route stays closed until verification completes, recovery preserves entered credentials, and repeated quiet configuration checks—including HTTP and business 429 responses—use inline feedback. Other requests retain their existing throttling notices.
Validation on
98832099: nine focused suites / 122 tests, ESLint, bilingual copy checks, TypeScript and the production build passed. Nine actual Chromium checks passed, including repeated throttling without modal/toast interruptions; eight final screenshots were captured and inspected outside Git. The old CI punctuation failure was corrected in this commit; current-head CI is tracked separately.Before/after screenshots and the Hubble issue record are available to authorized readers. The task owner explicitly requires screenshots to stay outside Git. Native public GitHub image upload is unavailable in this connection.
Source review: hugegraph#98
Visual overview
Unverified Server connections receive inline status and retry guidance before normal sign-in; entered credentials are preserved. Concept diagram, not authentication or security acceptance.