Skip to content

Fix JaCoCo coverage for multiple test tasks. - #40164

Open
singhmrinal02 wants to merge 1 commit into
apache:masterfrom
singhmrinal02:master
Open

singhmrinal02 wants to merge 1 commit into
apache:masterfrom
singhmrinal02:master

Conversation

@singhmrinal02

Copy link
Copy Markdown

Addresses #18194.

What

I looked into this issue and found that the JaCoCo config was only
taking test.exec into account.

There are some other test tasks like needsRunnerTests and
validatesRunner which can also generate .exec files. Since those
files weren't being picked up, their coverage wasn't included in the
final report.

So I changed it to pick up all the .exec files from the build/jacoco
directory instead of only test.exec.

Testing

I ran:

  • ./gradlew :buildSrc:compileGroovy — passed
  • ./gradlew :runners:direct-java:needsRunnerTests — 997 tests completed,
    17 failed, 4 skipped

@github-actions github-actions Bot added the build label Sep 17, 2026
@singhmrinal02

Copy link
Copy Markdown
Author

Hey! Just wanted to mention that this is actually my first ever open-source contribution. When I first opened the Beam project, I was honestly pretty overwhelmed and I’m still figuring things out.
If you get some time, I’d really appreciate some feedback on this PR — like what I did right, what I could have done better, or if I should have approached anything differently.
Also, any general tips on how I can become a better contributor and understand projects like this would be really helpful. I’m still pretty new to all of this and want to learn.
And if this isn’t something people usually ask in PRs, no worries . I just thought I’d ask since it’s my first contribution.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @Amar3tto for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant