You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I looked into this issue and found that the JaCoCo config was only
taking test.exec into account.
There are some other test tasks like needsRunnerTests and validatesRunner which can also generate .exec files. Since those
files weren't being picked up, their coverage wasn't included in the
final report.
So I changed it to pick up all the .exec files from the build/jacoco
directory instead of only test.exec.
Hey! Just wanted to mention that this is actually my first ever open-source contribution. When I first opened the Beam project, I was honestly pretty overwhelmed and I’m still figuring things out.
If you get some time, I’d really appreciate some feedback on this PR — like what I did right, what I could have done better, or if I should have approached anything differently.
Also, any general tips on how I can become a better contributor and understand projects like this would be really helpful. I’m still pretty new to all of this and want to learn.
And if this isn’t something people usually ask in PRs, no worries . I just thought I’d ask since it’s my first contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #18194.
What
I looked into this issue and found that the JaCoCo config was only
taking
test.execinto account.There are some other test tasks like
needsRunnerTestsandvalidatesRunnerwhich can also generate.execfiles. Since thosefiles weren't being picked up, their coverage wasn't included in the
final report.
So I changed it to pick up all the
.execfiles from thebuild/jacocodirectory instead of only
test.exec.Testing
I ran:
./gradlew :buildSrc:compileGroovy— passed./gradlew :runners:direct-java:needsRunnerTests— 997 tests completed,17 failed, 4 skipped