Enforce provider-only JMSX properties under strictCompliance - #1853
pradeep85841 wants to merge 5 commits into
Conversation
pradeep85841
commented
Mar 28, 2026
pradeep85841
commented
- Throws a MessageNotWriteableException if a client attempts to set JMSXDeliveryCount, JMSXRcvTimestamp, JMSXState, JMSXProducerTXID, or JMSXConsumerTXID.
- Client-set properties (like JMSXGroupID and JMSXGroupSeq) are completely bypassed and function normally.
- Added StrictComplianceProviderJMSXPropertyTest using an embedded BrokerService to explicitly verify both strict and legacy behaviors.
|
Hi @jbonofre, just a quick ping on this! The changes are pushed with JMSException and the corrected imports. Let me know if anything else is needed |
|
@pradeep85841 thanks ! Let me do a new pass. |
|
Updated the "Wait.waitFor" condition in "testNetworkAdvancedStatistics". The test now waits for the broker to finish updating its background metrics (like enqueues and dequeues) before doing the final checks. |
|
Hi @jbonofre , just checking in! Both the main PR updates (exception/imports) and the fix for the flaky CI test are pushed. Let me know if you can kick off the CI checks again! |
| // Strict Compliance Check For Provider-Set JMSX Properties | ||
| ActiveMQConnection conn = getConnection(); | ||
| if (conn != null && conn.isStrictCompliance()) { | ||
| if ("JMSXDeliveryCount".equals(name) || |
There was a problem hiding this comment.
I think a constant final public static set would make more sense here vs each property listed out by string name.
|
Is the network metrics fix commit already merged? That should probably be a separate PR that can be merged quickly |
c9e2e1e to
697086d
Compare
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Vector; | ||
| import java.util.*; |
There was a problem hiding this comment.
Please don't reduce imports to wildcard. It is a common IDE setting, but we don't have the code style rules applied to catch it.
|
@mattrpav, My IDE auto-collapsed them when I added the Set classes. I've expanded them back to explicit imports and updated my local settings so it won't happen again. The fix is pushed |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.5.0
| ActiveMQConnection conn = getConnection(); | ||
| if (conn != null && conn.isStrictCompliance()) { | ||
| if (STRICT_PROVIDER_JMSX_PROPERTIES.contains(name)) { | ||
| throw new JMSException("Provider-set JMSX property '" + name + "' cannot be set by a client under strict compliance."); |
There was a problem hiding this comment.
Please update this exception to throw MessageNotWriteableException to be spec-aligned.
|
Hi @mattrpav, I've updated the exception to MessageNotWriteableException. |
3 participants
