Repository navigation
fix: start the XanV2Vesting recipients as an empty list - #201
Merged
heueristik merged 1 commit intoOct 16, 2026
Merged
heueristik merged 1 commit into
heueristik merged 1 commit into
Conversation
The placeholder recipient, address(1) with 1 XAN, produced a payload that passed CI and targeted the real proxy. Submitted by mistake, it would add a principal that can never unlock and cannot be removed. An empty list produces addRecipients([]), which adds nothing. The generator no longer rejects an empty list: that guard came from the deploy script, which no longer reads the recipients. Refs #184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up from reviewing #184. the recipients file starts as an empty list instead of
address(1)with 1 XAN, so the committed payload isaddRecipients([])and adds nothing if someone submits it before the real list lands. the generator's empty-list guard goes away: it came from the deploy script, which no longer reads the recipients.