Repository navigation
refactor!: add the XanV2Vesting recipients only through addRecipients - #199
Merged
heueristik merged 3 commits intoOct 14, 2026
Merged
heueristik merged 3 commits into
heueristik merged 3 commits into
Conversation
heueristik
deleted the
heueristik/xan-v2-vesting-no-initial-recipients
branch
October 14, 2026 10:37
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the recipients from
XanV2Vesting.initialize. The council multisig, which owns the proxy, adds all recipients withaddRecipientsafter the deployment. The deployment therefore no longer depends on the recipient list.Contract and script:
initialize(address initialOwner)sets the owner and emitsVestingScheduled. The proxy starts without recipients.addRecipientsholds the loop of the removed_addRecipients, which had no other caller.DeployXanV2Vesting.deploy(deployer)replacesdeploy(deployer, recipients).readRecipients,RECIPIENTS_PATH, andZeroRecipientsNotAllowedare removed.Tests:
addRecipientsas the owner, so the tests that use it start from the same state as before.initializetoaddRecipients.XanV2Vestingand its deploy script stays at 100%, and lint and Slither are clean.Docs:
docs/03-XanV2Vesting.mdandDEPLOYMENT.mddescribe adding the recipients after the deployment. InDEPLOYMENT.md, the address check moves after the deployment, before the new step "Add the recipients".script/xan-v2-vesting-recipients.jsonstays. A follow-up PR adds a script that reads it and proposes theaddRecipientscall to the council multisig.Check:
DEPLOYMENT.mdsection 5: the council multisig adds the recipients before it computes and sends the first top-up, because the top-up scripts read the principals from the proxy.initializechanges. The contract is not deployed yet, so no deployment is affected.