Repository navigation
Conversation
On machines with no ALSA devices or PipeWire/PulseAudio sockets, such as GitHub's runners, --audio has nothing to bind, so starting a sandbox with it doesn't change anything. The test's "changing audio requires a restart" check then can't fail, which has kept the coverage workflow failing since audio support was added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bottom of the stack. Fixes the Coverage Testing workflow, which has failed on every run since audio support was added (#25, #26 and #28 inherit the failure).
ai_test_audio_mounted_in_sandboxchecks that turning on--audiofor a running sandbox is rejected until the sandbox is restarted. On machines with no ALSA devices or PipeWire/PulseAudio sockets, such as GitHub's runners,--audiohas nothing to bind, so it doesn't change the sandbox and the rejection never happens:The test now skips when there are no audio paths to check. On machines with audio it runs as before; I ran it locally and the file's 7 tests pass.