Skip to content

Skip the audio mount test on machines without audio - #29

Merged
anoek merged 1 commit into
mainfrom
fix-ci
Oct 31, 2026
Merged

anoek merged 1 commit into
mainfrom
fix-ci

Conversation

@anoek

@anoek anoek commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Bottom of the stack. Fixes the Coverage Testing workflow, which has failed on every run since audio support was added (#25, #26 and #28 inherit the failure).

ai_test_audio_mounted_in_sandbox checks that turning on --audio for a running sandbox is rejected until the sandbox is restarted. On machines with no ALSA devices or PipeWire/PulseAudio sockets, such as GitHub's runners, --audio has nothing to bind, so it doesn't change the sandbox and the rejection never happens:

thread 'ai_test_audio_mounted_in_sandbox' panicked at tests/ai_test_audio.rs:142:5:
assertion failed: sandbox.xfail(&["--no-config", "--audio", "true"])

The test now skips when there are no audio paths to check. On machines with audio it runs as before; I ran it locally and the file's 7 tests pass.

On machines with no ALSA devices or PipeWire/PulseAudio sockets, such as
GitHub's runners, --audio has nothing to bind, so starting a sandbox with
it doesn't change anything. The test's "changing audio requires a
restart" check then can't fail, which has kept the coverage workflow
failing since audio support was added.
@anoek
anoek added this pull request to stack #30 October 31, 2026 13:31
@anoek
anoek merged commit c71fe58 into main Oct 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant