Repository navigation
chore(deps): rolling dependency upgrades - #671
prasanna-anchorage wants to merge 1 commit into
Conversation
No advisory from today's cargo-audit run is fixed by a major bump of a
chain-crate dependency (the eligible candidates all trace to git deps or to
non-chain-crate infra), and no used direct dependency already has a newer
major elsewhere in the tree that this removes a duplicate by aligning with.
Picked as a tier-(c) fallback: visualsign-solana's own direct dependency,
furthest behind among candidates that pass the gates cleanly.
- Target 4.0.0 published 2026-10-28 (14 days old at run time), not yanked.
- cascades two of its own transitive deps in lockstep:
solana-instructions-sysvar 3.0.1 -> 4.0.0, spl-token-confidential-transfer-
proof-extraction 0.6.1 -> 0.7.0 (plus solana-zk-elgamal-proof-interface
0.1.3 -> 1.0.0, new).
- Duplicate-version count unchanged for every touched crate (no crate gained
an additional distinct major): solana-instructions-sysvar stays at 2
majors {2.2.2, 4.0.0} (was {2.2.2, 3.0.1}),
spl-token-confidential-transfer-proof-extraction stays at 3 majors
{0.3.0, 0.4.1, 0.7.0} (was {0.3.0, 0.4.1, 0.6.1}).
- No source changes required: visualsign-solana builds and its full test
suite (including the offline surfpool_fuzz IDL roundtrips) passes
unchanged against the new major.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014SKL1JWSWG9Cp884twW6eF
There was a problem hiding this comment.
🔵 Needs a closer look
The signing-display decoder upgrade adds pinocchio/account-view dependencies with unavailable implementation and provenance, requiring human dependency review and pending affected-workspace CI results.
No open issues 🎉
What changed in this PR
Updates the Solana parser’s Token-2022 dependency as part of ongoing dependency maintenance, without changing parser source code.
Changes:
- Upgrades
spl-token-2022-interfacefrom 3.1.2 to 4.0.0. - Refreshes the workspace lockfile with related Solana dependencies and several existing dependency resolutions.
| File | Description |
|---|---|
src/chain_parsers/visualsign-solana/Cargo.toml |
Updates the Token-2022 interface dependency to 4.0.0. |
src/Cargo.lock |
Locks the upgraded dependency graph, including new Pinocchio and Solana view crates. |
Review effort: Balanced
|
2026-11-12: added nothing; dropped nothing; rebased onto main ac31044 (no-op — main was already an ancestor of this branch). 🤖 Generated with Claude Code https://claude.ai/code/session_014SKL1HmQdWEqbFXk4iQhvj Generated by Claude Code |
|
2026-11-13: added nothing; dropped nothing; rebased onto main ac31044 (fast-forward, no new main commits to replay). Generated by Claude Code |
|
2026-11-16: added nothing; dropped nothing; rebased onto main Generated by Claude Code |
|
2026-11-17: added nothing; dropped nothing (k256 0.13->0.14, alloy-consensus 1.2.1->2.5.0, and bcs 0.1.6->0.2.1 were attempted and reverted before commit — see PR description for why); rebased onto main 5a1cd6c (already up to date, no-op). 🤖 Generated with Claude Code https://claude.ai/code/session_014SKL1HpjJfvFX7nz4C6D4B Generated by Claude Code |
Rolling dependency-upgrade branch (
deps/daily). This PR persists across days; see the per-day comment thread below for history.Commits on this branch
chore(deps/solana): spl-token-2022-interface 3.1.2 -> 4.0.0 (major)— added 2026-11-11Overlapping Dependabot PRs
None. Open Dependabot PRs as of today (#672 cargo-tvc-deploy group, #659 ethereum-fuzz
rand, #660 npm intools/cloudflare-x402-poc) touch onlytools/tvc-deploy/Cargo.lock,src/chain_parsers/visualsign-ethereum/fuzz/Cargo.lock, and npm manifests — none touchsrc/Cargo.lockor any chain crate'sCargo.toml, andgit merge-treeshows no conflicts against any of them.Major upgrade added today
None. Three candidates were evaluated and rejected after real verification (not just inspection):
^0.7.5. near/intents'p256(via the pinneddefuse/v0.4.2tag) still requireselliptic-curve ^0.13, so this would add a third major of elliptic-curve/ecdsa/crypto-bigint/sha2/signature to the tree instead of converging — fails the duplicate-version gate outright. Not applied.sha3(two new versions: 0.10.8, 0.11.0),keccak(two new versions: 0.1.6, 0.2.2 replacingtiny-keccak), andwinnow(two new versions) —sha3ends up inparser_appalongside the existingsha2/hash-crate stack, so this fragments a crypto hash crate into two majors at once. Fails the duplicate-version gate; reverted.move-core-types(MystenLabs/sui git dep, tagmainnet-v1.68.1) requiresbcs ^0.1.4, so 0.2.x can't resolve at all without the Sui pin moving first. Reverted.anychain-tron(crates.io, latest 0.2.14, no newer major) pinsprotobuf ^3, and visualsign-tron'sprotobuf::Messageusage operates on types generated by anychain-tron, so an independent major bump would either fail to resolve or produce two incompatibleprotobufcrate instances.No other chain-crate direct dependency is behind by a major version; the rest of the duplicate-version baseline traces to transitive/test-only/infra dependencies (solana-client, hyper/axum, fastcrypto) outside the six chain crates' own
Cargo.tomls.near/intents
None. Newest tag passing the 7-day git cooldown is
defuse/v0.4.5(commit16d04f6ec4401263f8914638710260da50bb46b0, committed 2026-10-07). Howeverdefuse/v0.4.3already removes thedefuse-deadlinecrate entirely (the wholeDeadlinewrapper type is gone upstream; deadlines are now a bareTimestampcompared inline indefuse-core's engine).visualsign-intents/src/render.rscallsdefuse_deadline::Deadline::new(...)directly, so adopting any tag pastv0.4.2needs a real migration of that call site, not a minimal fix — out of scope for this routine. Flagged under Needs attention for a human-driven follow-up.Git dependencies
near/intents(defuse-core, defuse-crypto, defuse-deadline)defuse/v0.4.26dad94cf8a9cf3083d9c1cf6c052ef8cdde0d473(tag integrity OK, no drift)defuse/v0.4.5committed 2026-10-07defuse-deadlinecrate removed upstream as of v0.4.3 — non-minimal migration needed (see above)anchorageoss/solana-parser(solana_parser, solana-parser-fuzz-core)2c48758cdae9b0cbb319d90a03bd80221edd44f4(full 40-char SHA)main, same commit date 2026-11-07)MystenLabs/sui(move-core-types, move-bytecode-utils, sui-types, sui-json-rpc-types)mainnet-v1.68.13c0f387ebb40b8be292d3b7bd3f5bee8ad226d33(tag integrity OK, no drift)mainnet-v1.*tags; newestmainnet-v1.83.1committed 2026-11-03;mainHEAD committed 2026-11-16fastcrypto)cargo update --dry-runfails today:multihash 0.17.0requires yankedcore2 0.4.0viamultiaddr -> mysten-network -> sui-typestkhq/qos(qos_client, qos_core, qos_crypto, qos_hex, qos_net, qos_nsm, qos_p256, qos_test_primitives)82d8e18b8875362cdb639f962b6a7f78bd42d320(full 40-char SHA)main(main HEAD 2026-11-16, pinned commit 2026-07-09)vsss-rs)Security audit
Baseline (unchanged today, since no upgrade was kept): 38 vulnerabilities (cargo-audit), 43 allowed warnings (unmaintained/unsound/yanked), before = after.
Classification of all 38:
(i) Semver-compatible fix available — Dependabot's job. No open Dependabot PR currently covers
src/Cargo.lock, so these are flagged under Needs attention rather than fixed here: RUSTSEC-2026-0204 (crossbeam-epoch), RUSTSEC-2026-0258 (h2 0.4.12 instance only), RUSTSEC-2026-0523/0341/0339/0342/0338/0524 (quinn-proto, all fixed within 0.11.x), RUSTSEC-2026-0538 (quinn-udp), RUSTSEC-2026-0001 (rkyv, fixed at 0.7.46), RUSTSEC-2026-0220 (ruint), RUSTSEC-2026-0348/0346/0347/0349 (rustls 0.23.45 instance), RUSTSEC-2026-0382 (rustls-webpki 0.103.15 instance), RUSTSEC-2026-0383 (webpki-root-certs), RUSTSEC-2026-0381 (webpki-roots 1.0.5 instance), RUSTSEC-2026-0391 (zstd), RUSTSEC-2026-0398/0403 (zstd-safe), RUSTSEC-2026-0410 (zstd-sys).(ii) Needs a major bump of a direct chain-crate dependency. RUSTSEC-2026-0387 (crypto-bigint 0.5.5, via k256 in visualsign-ethereum) — attempted today (see "Major upgrade" above), fails the duplicate-version gate; no fix applied.
(iii) Blocked by a git dep, a non-chain-crate consumer, or no upstream fix.
tkhq/qos/vsss-rs) — report-only git dep.MystenLabs/sui/fastcrypto) — report-only git dep.ed25519-dalek-bip32 -> solana-keypair -> solana-client -> solana_test_utils(a test-only workspace crate, not one of the six chain crates).hyper 0.14 -> axum 0.6 -> metrics(infra crate).rust_decimal -> x402-* -> parser_gateway(payment-gateway crate, not a chain crate).tokio-tungstenite -> solana-pubsub-client/solana-tpu-client -> solana-client -> solana_test_utils(test-only workspace crate).Not upgraded
v0.4.2: evaluated, skipped — see "near/intents".Unused (remove, don't upgrade)
None —
cargo machetereports zero unused dependencies in the workspace.Insight
cargo tree -d --depth 0) is large and mostly pre-existing (sha2 across 0.9/0.10/0.11, base64 across four majors, thiserror 1 vs 2, etc.), almost entirely from transitive/test-only paths (solana_test_utils's crates.iosolana-client, which drags in an oldtungstenite/rustls 0.21/webpki-rootsstack) rather than from the six chain crates' own declared dependencies, which are already pinned to the newest major present in the lock wherever one exists.MystenLabs/suiis both the furthest-behind git pin (19 tags, ~2 weeks of upstream commits past the newest tag) and the thing currently blocking a cleancargo update --dry-run(yankedcore2viamultihash) — the planned human-driven Sui upgrade would likely clear that blocker as a side effect.defuse-deadlinebetween v0.4.2 and v0.4.3 as part of a largerTimestamp-based rework of the engine's expiry checks; thedefuse/v0.4.5tag's commit (2026-10-07) is well past cooldown, so this is ready to adopt as soon as a human portsvisualsign-intents/src/render.rs'sDeadline::new(...)call site.One improvement suggestion
Add a
cargo-deny(or equivalentbanscheck) CI job that fails on a crate gaining an additional major version inCargo.lock, scoped to the security-relevant crate families already called out in this routine's rules (k256/p256/ecdsa/elliptic-curve/sha2/sha3/crypto-bigint/signature/rand_core/ed25519 family). Today that gate only runs inside this manual routine's reasoning; a CI check would catch the same class of regression (like thesha3/keccakfragmentation found above) on any PR, not just this one.CI status
Green on the current head commit (
5a1cd6c): CodeQL, ubuntu, gate, no-c-ios, and all required checks pass;proptest/fuzz/regtest/bench/surfpoolare skipped (label-gated, not required). Nothing changed on the branch today, so no new CI run was needed.🤖 Generated with Claude Code
https://claude.ai/code/session_014SKL1HpjJfvFX7nz4C6D4B