Skip to content

chore(deps): rolling dependency upgrades - #671

Open
prasanna-anchorage wants to merge 1 commit into
mainfrom
deps/daily
Open

prasanna-anchorage wants to merge 1 commit into
mainfrom
deps/daily

Conversation

@prasanna-anchorage

@prasanna-anchorage prasanna-anchorage commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Rolling dependency-upgrade branch (deps/daily). This PR persists across days; see the per-day comment thread below for history.

Commits on this branch

  • chore(deps/solana): spl-token-2022-interface 3.1.2 -> 4.0.0 (major) — added 2026-11-11

Overlapping Dependabot PRs

None. Open Dependabot PRs as of today (#672 cargo-tvc-deploy group, #659 ethereum-fuzz rand, #660 npm in tools/cloudflare-x402-poc) touch only tools/tvc-deploy/Cargo.lock, src/chain_parsers/visualsign-ethereum/fuzz/Cargo.lock, and npm manifests — none touch src/Cargo.lock or any chain crate's Cargo.toml, and git merge-tree shows no conflicts against any of them.

Major upgrade added today

None. Three candidates were evaluated and rejected after real verification (not just inspection):

  • k256 0.13 -> 0.14 (visualsign-ethereum direct dep; would fix RUSTSEC-2026-0387 / crypto-bigint, candidate tier (a)): elliptic-curve 0.14.x (pulled by k256 0.14) requires crypto-bigint ^0.7.5. near/intents' p256 (via the pinned defuse/v0.4.2 tag) still requires elliptic-curve ^0.13, so this would add a third major of elliptic-curve/ecdsa/crypto-bigint/sha2/signature to the tree instead of converging — fails the duplicate-version gate outright. Not applied.
  • alloy-consensus 1.2.1 -> 2.5.0 (tier (c), most-outdated used direct dep of visualsign-ethereum, newest version in the 2.x line passing the 7-day cooldown): applied and built cleanly, but introduced sha3 (two new versions: 0.10.8, 0.11.0), keccak (two new versions: 0.1.6, 0.2.2 replacing tiny-keccak), and winnow (two new versions) — sha3 ends up in parser_app alongside the existing sha2/hash-crate stack, so this fragments a crypto hash crate into two majors at once. Fails the duplicate-version gate; reverted.
  • bcs 0.1.6 -> 0.2.1 (tier (c), visualsign-sui direct dep): blocked outright — move-core-types (MystenLabs/sui git dep, tag mainnet-v1.68.1) requires bcs ^0.1.4, so 0.2.x can't resolve at all without the Sui pin moving first. Reverted.
  • protobuf 3.x -> 4.x (visualsign-tron) was also considered but ruled out without attempting: anychain-tron (crates.io, latest 0.2.14, no newer major) pins protobuf ^3, and visualsign-tron's protobuf::Message usage operates on types generated by anychain-tron, so an independent major bump would either fail to resolve or produce two incompatible protobuf crate instances.

No other chain-crate direct dependency is behind by a major version; the rest of the duplicate-version baseline traces to transitive/test-only/infra dependencies (solana-client, hyper/axum, fastcrypto) outside the six chain crates' own Cargo.tomls.

near/intents

None. Newest tag passing the 7-day git cooldown is defuse/v0.4.5 (commit 16d04f6ec4401263f8914638710260da50bb46b0, committed 2026-10-07). However defuse/v0.4.3 already removes the defuse-deadline crate entirely (the whole Deadline wrapper type is gone upstream; deadlines are now a bare Timestamp compared inline in defuse-core's engine). visualsign-intents/src/render.rs calls defuse_deadline::Deadline::new(...) directly, so adopting any tag past v0.4.2 needs a real migration of that call site, not a minimal fix — out of scope for this routine. Flagged under Needs attention for a human-driven follow-up.

Git dependencies

Repo Pin Resolved commit Newer tags/commits Advisories attributed Blocker Policy
near/intents (defuse-core, defuse-crypto, defuse-deadline) tag defuse/v0.4.2 6dad94cf8a9cf3083d9c1cf6c052ef8cdde0d473 (tag integrity OK, no drift) 3 newer tags (v0.4.3, v0.4.4, v0.4.5); newest defuse/v0.4.5 committed 2026-10-07 none defuse-deadline crate removed upstream as of v0.4.3 — non-minimal migration needed (see above) candidate for step 6; blocked this run
anchorageoss/solana-parser (solana_parser, solana-parser-fuzz-core) rev 2c48758cdae9b0cbb319d90a03bd80221edd44f4 (full 40-char SHA) same (0 commits behind main, same commit date 2026-11-07) up to date none none report-only (our fork; fixes land there first, then a human moves the rev)
MystenLabs/sui (move-core-types, move-bytecode-utils, sui-types, sui-json-rpc-types) tag mainnet-v1.68.1 3c0f387ebb40b8be292d3b7bd3f5bee8ad226d33 (tag integrity OK, no drift) 19 newer mainnet-v1.* tags; newest mainnet-v1.83.1 committed 2026-11-03; main HEAD committed 2026-11-16 RUSTSEC-2023-0071 (rsa 0.8.2, via fastcrypto) yes — cargo update --dry-run fails today: multihash 0.17.0 requires yanked core2 0.4.0 via multiaddr -> mysten-network -> sui-types report-only (large jump; planned human-driven upgrade)
tkhq/qos (qos_client, qos_core, qos_crypto, qos_hex, qos_net, qos_nsm, qos_p256, qos_test_primitives) rev 82d8e18b8875362cdb639f962b6a7f78bd42d320 (full 40-char SHA) same ~154 commits behind main (main HEAD 2026-11-16, pinned commit 2026-07-09) RUSTSEC-2026-0387 (crypto-bigint 0.6.1, via vsss-rs) none report-only (rev bump changes enclave measurements/attestation; manual only)

Security audit

Baseline (unchanged today, since no upgrade was kept): 38 vulnerabilities (cargo-audit), 43 allowed warnings (unmaintained/unsound/yanked), before = after.

Classification of all 38:

(i) Semver-compatible fix available — Dependabot's job. No open Dependabot PR currently covers src/Cargo.lock, so these are flagged under Needs attention rather than fixed here: RUSTSEC-2026-0204 (crossbeam-epoch), RUSTSEC-2026-0258 (h2 0.4.12 instance only), RUSTSEC-2026-0523/0341/0339/0342/0338/0524 (quinn-proto, all fixed within 0.11.x), RUSTSEC-2026-0538 (quinn-udp), RUSTSEC-2026-0001 (rkyv, fixed at 0.7.46), RUSTSEC-2026-0220 (ruint), RUSTSEC-2026-0348/0346/0347/0349 (rustls 0.23.45 instance), RUSTSEC-2026-0382 (rustls-webpki 0.103.15 instance), RUSTSEC-2026-0383 (webpki-root-certs), RUSTSEC-2026-0381 (webpki-roots 1.0.5 instance), RUSTSEC-2026-0391 (zstd), RUSTSEC-2026-0398/0403 (zstd-safe), RUSTSEC-2026-0410 (zstd-sys).

(ii) Needs a major bump of a direct chain-crate dependency. RUSTSEC-2026-0387 (crypto-bigint 0.5.5, via k256 in visualsign-ethereum) — attempted today (see "Major upgrade" above), fails the duplicate-version gate; no fix applied.

(iii) Blocked by a git dep, a non-chain-crate consumer, or no upstream fix.

  • RUSTSEC-2026-0387 (crypto-bigint 0.6.1, via tkhq/qos/vsss-rs) — report-only git dep.
  • RUSTSEC-2023-0071 (rsa 0.8.2, via MystenLabs/sui/fastcrypto) — report-only git dep.
  • RUSTSEC-2024-0344 (curve25519-dalek 3.2.0) and RUSTSEC-2022-0093 (ed25519-dalek 1.0.1) — both via ed25519-dalek-bip32 -> solana-keypair -> solana-client -> solana_test_utils (a test-only workspace crate, not one of the six chain crates).
  • RUSTSEC-2026-0258 (h2 0.3.27 instance) — via hyper 0.14 -> axum 0.6 -> metrics (infra crate).
  • RUSTSEC-2026-0235 (rkyv, needs >=0.8.17, no 0.7.x fix) — via rust_decimal -> x402-* -> parser_gateway (payment-gateway crate, not a chain crate).
  • RUSTSEC-2026-0346/0349 (rustls 0.21.12 instance), RUSTSEC-2026-0099/0382/0104/0098 (rustls-webpki 0.101.7), RUSTSEC-2026-0381 (webpki-roots 0.24.0/0.25.4 instances) — all via tokio-tungstenite -> solana-pubsub-client/solana-tpu-client -> solana-client -> solana_test_utils (test-only workspace crate).

Not upgraded

  • k256 0.13 -> 0.14, alloy-consensus 1.2.1 -> 2.5.0, bcs 0.1.6 -> 0.2.1: attempted, reverted — see "Major upgrade added today".
  • near/intents tag beyond v0.4.2: evaluated, skipped — see "near/intents".
  • All git dependencies other than near/intents: pinned per policy (report-only), see table above.

Unused (remove, don't upgrade)

None — cargo machete reports zero unused dependencies in the workspace.

Insight

  • The dependency-duplication baseline (cargo tree -d --depth 0) is large and mostly pre-existing (sha2 across 0.9/0.10/0.11, base64 across four majors, thiserror 1 vs 2, etc.), almost entirely from transitive/test-only paths (solana_test_utils's crates.io solana-client, which drags in an old tungstenite/rustls 0.21/webpki-roots stack) rather than from the six chain crates' own declared dependencies, which are already pinned to the newest major present in the lock wherever one exists.
  • MystenLabs/sui is both the furthest-behind git pin (19 tags, ~2 weeks of upstream commits past the newest tag) and the thing currently blocking a clean cargo update --dry-run (yanked core2 via multihash) — the planned human-driven Sui upgrade would likely clear that blocker as a side effect.
  • The near/intents upstream removed defuse-deadline between v0.4.2 and v0.4.3 as part of a larger Timestamp-based rework of the engine's expiry checks; the defuse/v0.4.5 tag's commit (2026-10-07) is well past cooldown, so this is ready to adopt as soon as a human ports visualsign-intents/src/render.rs's Deadline::new(...) call site.

One improvement suggestion

Add a cargo-deny (or equivalent bans check) CI job that fails on a crate gaining an additional major version in Cargo.lock, scoped to the security-relevant crate families already called out in this routine's rules (k256/p256/ecdsa/elliptic-curve/sha2/sha3/crypto-bigint/signature/rand_core/ed25519 family). Today that gate only runs inside this manual routine's reasoning; a CI check would catch the same class of regression (like the sha3/keccak fragmentation found above) on any PR, not just this one.

CI status

Green on the current head commit (5a1cd6c): CodeQL, ubuntu, gate, no-c-ios, and all required checks pass; proptest/fuzz/regtest/bench/surfpool are skipped (label-gated, not required). Nothing changed on the branch today, so no new CI run was needed.

🤖 Generated with Claude Code

https://claude.ai/code/session_014SKL1HpjJfvFX7nz4C6D4B

No advisory from today's cargo-audit run is fixed by a major bump of a
chain-crate dependency (the eligible candidates all trace to git deps or to
non-chain-crate infra), and no used direct dependency already has a newer
major elsewhere in the tree that this removes a duplicate by aligning with.
Picked as a tier-(c) fallback: visualsign-solana's own direct dependency,
furthest behind among candidates that pass the gates cleanly.

- Target 4.0.0 published 2026-10-28 (14 days old at run time), not yanked.
- cascades two of its own transitive deps in lockstep:
  solana-instructions-sysvar 3.0.1 -> 4.0.0, spl-token-confidential-transfer-
  proof-extraction 0.6.1 -> 0.7.0 (plus solana-zk-elgamal-proof-interface
  0.1.3 -> 1.0.0, new).
- Duplicate-version count unchanged for every touched crate (no crate gained
  an additional distinct major): solana-instructions-sysvar stays at 2
  majors {2.2.2, 4.0.0} (was {2.2.2, 3.0.1}),
  spl-token-confidential-transfer-proof-extraction stays at 3 majors
  {0.3.0, 0.4.1, 0.7.0} (was {0.3.0, 0.4.1, 0.6.1}).
- No source changes required: visualsign-solana builds and its full test
  suite (including the offline surfpool_fuzz IDL roundtrips) passes
  unchanged against the new major.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014SKL1JWSWG9Cp884twW6eF

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The signing-display decoder upgrade adds pinocchio/account-view dependencies with unavailable implementation and provenance, requiring human dependency review and pending affected-workspace CI results.

No open issues 🎉

What changed in this PR

Updates the Solana parser’s Token-2022 dependency as part of ongoing dependency maintenance, without changing parser source code.

Changes:

  • Upgrades spl-token-2022-interface from 3.1.2 to 4.0.0.
  • Refreshes the workspace lockfile with related Solana dependencies and several existing dependency resolutions.
File Description
src/​chain_parsers/​visualsign-solana/​Cargo.toml Updates the Token-2022 interface dependency to 4.0.0.
src/​Cargo.lock Locks the upgraded dependency graph, including new Pinocchio and Solana view crates.

Review effort: Balanced

Copy link
Copy Markdown
Contributor Author

2026-11-12: added nothing; dropped nothing; rebased onto main ac31044 (no-op — main was already an ancestor of this branch).


🤖 Generated with Claude Code

https://claude.ai/code/session_014SKL1HmQdWEqbFXk4iQhvj


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

2026-11-13: added nothing; dropped nothing; rebased onto main ac31044 (fast-forward, no new main commits to replay).


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

2026-11-16: added nothing; dropped nothing; rebased onto main ac31044 (fast-forward, no-op — branch head unchanged at 5a1cd6c).


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

2026-11-17: added nothing; dropped nothing (k256 0.13->0.14, alloy-consensus 1.2.1->2.5.0, and bcs 0.1.6->0.2.1 were attempted and reverted before commit — see PR description for why); rebased onto main 5a1cd6c (already up to date, no-op).

🤖 Generated with Claude Code

https://claude.ai/code/session_014SKL1HpjJfvFX7nz4C6D4B


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants