Repository navigation
Add icon overrides; remove MessageButton; rename TextButton ghost to subtle - #122
Merged
Merged
Conversation
pszerzo-amazon
changed the title
pszerzo-amazon
force-pushed
the
icon-overrides
branch
2 times, most recently
from
October 26, 2026 17:49
c8cd719 to
f753ed9
Compare
sderacy
previously approved these changes
Oct 26, 2026
…subtle - Add `icons` option (also via `update()`) to replace any built-in icon by its `Icons` key; components read icons through a new `useIcons` hook. - Add `createIcon(children, svgProps?)`: 24x24 viewBox, `currentColor` fill, handles `size`/`className`/`aria-hidden`. Export it and the icon types. - TextButton: `subtle` is the new default variant; `ghost` remains an alias. - Remove MessageButton (component, exports, specimen). - Document icons in the README. Test
pszerzo-amazon
force-pushed
the
icon-overrides
branch
from
October 26, 2026 17:55
f753ed9 to
bbf8f6e
Compare
sderacy
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconsoption (also settable viaupdate()) replaces any built-in icon by itsIconskey. Components read icons through a newuseIconshook; the merged map is memoized, so identities stay stable across re-renders.createIcon(children, svgProps?): builds a custom icon with a 24x24viewBoxandcurrentColorfill, and appliessize,classNameandaria-hidden. Exported withIcon,IconProps,IconNameandIconOverrides.TextButton:subtleis the new default variant;ghoststill works as an alias.MessageButton: removed (component, exports, design-system specimen).Notes
accent20is intentionally unchanged; its usages are still to be decided.docs/is not regenerated (npm run update-readme).