Repository navigation
Implement command arguments #36
Description
Build support for passing flags to commands (for example git push --force-with-lease, or P-fp in Magit).
- Iterate on the Submenu ui layout of Gitu. Where do command flags fit in?
- Some arguments are enabled per default.
Reacted by frank-lenormand, Matt Gallagher and Danil Menkin
Reacted by Calum Sieppert
Activity
frank-lenormand commentedon Mar 13, 2024
Given
v0.6.2, I would recommend the following:Allow all lettered core commands to be called with the alt modifier.
Display all available optional flags in a new window, similar to the screenshot in the body of this issue:
If all available options have a single-letter flag (I think that’s the case), then hitting the associated key should enable that option.
For example:
-f/--forceforgit pushwould be used upon hitting thefkey.Otherwise, an arbitrary letter that doesn’t collide with the others on screen could be highlighted and used as trigger, similarly to how
btopdoes it:If an option requires an argument, a prompt could be displayed (in the case of an arbitrary value) or another window (in the case of a fixed set of choices).
Example:
HTH!
altsem commentedon Mar 13, 2024
I appreciate the input, think that most people would expect magit-like bindings out of gitu. I'm unfamiliar with btop, perhaps there's a way to design it configurable.
I know
altcan be problematic for mac terminal users with non-us layouts.Perhaps if the dash was included in the bindings table
-f(for --force-with-lease).You'd just have to copy the default keymap and change:
-f->fetc.
p->alt-pExternalizing keymap configuration becomes a whole other issue it feels like though.
mattgallagher92 commentedon Mar 19, 2024
I'm excited to see so much activity on this library! I use Magit with vi-style keybindings and would love to have a similar experience outside of Emacs.
Just wanted to note that this issue is the main blocker stopping me (so maybe others too?) from switching to gitu - I fairly regularly amend commits or interactively rebase branches that I've pushed, hence often force-with-lease-push too.
frank-lenormand commentedon Mar 20, 2024
I realised that the functionality needs to assume that multiple flags might need to be toggled, which the single-modifier proposal doesn’t solve.
Alternatively, here’s a way that e.g. Kitty (and some Vim-type bindings for the browser I can’t remember, whenever jumping to a hyperlink) uses:
In the menu that shows all possible flags to be passed to the underlying command, a special keyboard mapping is hit.
Example: shift+ctrl+e
Single letters (or combinations of successive letters, to avoid collisions) are highlighted on screen. They must be already visible prior to hitting the combination above, or be generated and inserted dynamically into view.
Examples (brackets = highlighted):
The use hits the highlighted letters/combinations associated with the flags to select.
Selected flags (or their associated letter) should be shown somewhere on the view.
Example:
Selected flags: -fHTH.
Yes, and a ton of work too! If you don’t particularly want to tackle this now, I reckon it’s best to focusing on finding good defaults, first.
feat: togglable argument 'force-with-lease' when pushing
feat: togglable argument '--force-with-lease' when pushing
altsem commentedon Mar 27, 2024
Got something working for a starter.
It only supports true/false flags, and it only introduces
--force-with-leaseso far. Should be easy to add more boolean flags now.feat: togglable argument '--force-with-lease' when pushing
feat: togglable argument '--force-with-lease' when pushing