Skip to content

feat(ssh): optionally import authorized public keys - #9

Merged
alsd4git merged 2 commits into
mainfrom
codex/ssh-authorized-keys
Nov 9, 2026
Merged

alsd4git merged 2 commits into
mainfrom
codex/ssh-authorized-keys

Conversation

@alsd4git

@alsd4git alsd4git commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Why

How

  • Validate keys, show fingerprints and destination, request confirmation, preserve existing entries, and make a backup before replacing them.
  • Handle Windows administrator shared keys and ACLs without changing sshd; run the installer lifecycle test only on explicitly disposable Windows environments.
  • Document limitations and manual revocation.

Tests

  • bash tests/test-ssh-key-import.sh: passed in WSL.
  • ShellCheck and shfmt on changed shell scripts: passed.
  • tests/windows-smoke.ps1: passed on PowerShell 5.1 and 7 with installer lifecycle skipped locally.
  • Windows Sandbox: real GitHub key import, dry-run and idempotence for the user and shared administrator destinations passed.
  • GitLab endpoint could not be verified live from this network (HTTP 403); HTTP/error handling is covered by isolated tests. Custom sshd configurations and address-specific Match rules still require manual confirmation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T19:22:48.690967Z b08a426 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alsd4git
alsd4git merged commit c5beb38 into main Nov 9, 2026
13 checks passed
@alsd4git
alsd4git deleted the codex/ssh-authorized-keys branch November 9, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant