Skip to content

fix(windows): harden NVM defaults and npm inventory - #8

Merged
alsd4git merged 1 commit into
mainfrom
codex/windows-nvm-hardening
Nov 9, 2026
Merged

alsd4git merged 1 commit into
mainfrom
codex/windows-nvm-hardening

Conversation

@alsd4git

@alsd4git alsd4git commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Why

  • Existing NVM installations without a default leave Node unusable, and failed npm inventory must not be treated as a safe migration.

How

  • Keep a verified default unchanged; install LTS when NVM has no default and its installed versions can be inspected.
  • Parse only the Default line, avoiding confusion with a previous version.
  • Stop migration when npm is missing, returns an error, or reports a package without a version.

Tests

  • powershell.exe -NoProfile -File tests/windows-node-tests.ps1 and PowerShell 7: passed with isolated fake NVM and npm commands.
  • git diff --check main..HEAD: passed.
  • Real migration of the earlier implementation was tested in Windows Sandbox; these additional failure cases have not been exercised in a fresh VM.

Related to #2. Further VM scenarios and end-to-end PATH checks remain open.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T18:18:03.291913Z c178fe5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alsd4git
alsd4git merged commit 0a993c7 into main Nov 9, 2026
17 checks passed
@alsd4git
alsd4git deleted the codex/windows-nvm-hardening branch November 9, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant