Repository navigation
fix(auth): add JWT expiration, issued-at claims, and token validation - #96
Open
Lakshya-2440 wants to merge 4 commits into
Open
Lakshya-2440 wants to merge 4 commits into
Lakshya-2440 wants to merge 4 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #34 (JWT expiry portion)
Summary
iatandexpclaims to auth tokens generated bycreate_token().verify_token()with configurable clock-skew leeway (leeway_seconds=60).DEFAULT_JWT_TTL_SECONDS = 604800(7 days) with environment override support viaenv.JWT_TTL_SECONDS.Optional[Dict[str, Any]]toverify_token().expsignature variable inverify_token()toexpected_sig.tests/test_tokens.py.What was wrong
create_token()encoded noexporiatclaims, andverify_token()never validated token timestamps. Leaked tokens remained valid indefinitely.expinverify_token()shadowed the expiration concept with HMAC signature hex string.Verification
python3 -m py_compile src/worker.py(syntax passes cleanly)pytest tests/test_tokens.py -v: 23 passed in 0.11sChecklist