Skip to content

Update Password Functionality Fixed - #139

Open
10done wants to merge 2 commits into
alphaonelabs:mainfrom
10done:fix/passwordcrash
Open

10done wants to merge 2 commits into
alphaonelabs:mainfrom
10done:fix/passwordcrash

Conversation

@10done

@10done 10done commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #138

Summary

  • POST /api/profile/password called validate_password_strength(new_password, username) before username was assigned, so every valid submit raised UnboundLocalError and returned 500.
  • The strength check now runs after the stored username is decrypted, which is the same name used to verify and hash the password.
  • A regression test signs in as alice and expects 200 with the confirmation message instead of that crash.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8832bedc-4425-4103-bef2-4d6150df2c82
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password change returns 500 because username is used before it is set

1 participant