Skip to content

fix(classroom): enhance virtual classroom sidebar, icon reliability, leave navigation, and slug titles - #105

Open
rishavvrajj wants to merge 3 commits into
alphaonelabs:mainfrom
rishavvrajj:fix/virtual-classroom-sidebar-and-navigation
Open

rishavvrajj wants to merge 3 commits into
alphaonelabs:mainfrom
rishavvrajj:fix/virtual-classroom-sidebar-and-navigation

Conversation

@rishavvrajj

@rishavvrajj rishavvrajj commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR addresses several usability and rendering issues in the Virtual Classroom and Activity views.

Participants Sidebar Enhancements

  • Made #participantsSidebar fully opaque with a 100% solid background in both light and dark modes.
  • Added a backdrop overlay (sidebarBackdrop) so users can close the sidebar by clicking outside it.
  • Added an Escape key listener to close the sidebar.
  • Styled participant cards (makeParticipantCard) with appropriate light/dark theme backgrounds and improved text contrast.
  • Added a visible close button with clear hover states.

Guaranteed Icon Rendering

  • Replaced all icon placeholders (data-lucide) across the lobby, top bar, chat room, and participant sidebar with robust inline SVGs.
  • Prevented icon rendering failures caused by delayed, blocked, or unavailable CDN scripts.

Activity Return Navigation on Leave

  • Updated the Leave button to navigate users directly back to their source activity details page (/activity/...).
  • Used stored return URLs with a referrer-based fallback for reliable navigation.

Clean Room IDs & Titles

  • Formatted slug-like activity titles and classroom room IDs to display with spaces instead of raw hyphens.
  • Example: why-is-redis-so-fast now appears as Why is redis so fast.

Screenshots

Screenshot 2026-10-15 111903 Screenshot 2026-10-15 111911

Testing

  • Verified that the participant sidebar is fully readable in both light and dark themes.
  • Verified that the sidebar closes using the close button, backdrop click, and Escape key.
  • Verified that all classroom icons render immediately without relying on external icon CDN scripts.
  • Verified that clicking Leave returns the user to the relevant /activity/<slug> page.
  • Verified that room IDs and activity titles display as readable text rather than raw URL slugs.

Closes #104 Assisted by AI using automatic multi-model routing, primarily Ollama.

…vigation, and slug formatting

- Make participants sidebar fully opaque in light and dark modes
- Add backdrop click and Escape key support to close sidebar
- Replace icon placeholders with robust inline SVGs across classroom and lobby
- Update Leave button to navigate directly back to activity detail page
- Format slug-based room IDs and activity titles with readable spaces
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: alphaonelabs/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9cfc6d07-cf6f-475e-91d1-8abfe92d461f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Opaque participant sidebar, inline icon rendering, Leave navigation, and slug title formatting

1 participant