Repository navigation
fix(classroom): enhance virtual classroom sidebar, icon reliability, leave navigation, and slug titles - #105
Open
rishavvrajj wants to merge 3 commits into
Conversation
…vigation, and slug formatting - Make participants sidebar fully opaque in light and dark modes - Add backdrop click and Escape key support to close sidebar - Replace icon placeholders with robust inline SVGs across classroom and lobby - Update Leave button to navigate directly back to activity detail page - Format slug-based room IDs and activity titles with readable spaces
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several usability and rendering issues in the Virtual Classroom and Activity views.
Participants Sidebar Enhancements
#participantsSidebarfully opaque with a 100% solid background in both light and dark modes.sidebarBackdrop) so users can close the sidebar by clicking outside it.Escapekey listener to close the sidebar.makeParticipantCard) with appropriate light/dark theme backgrounds and improved text contrast.Guaranteed Icon Rendering
data-lucide) across the lobby, top bar, chat room, and participant sidebar with robust inline SVGs.Activity Return Navigation on Leave
/activity/...).Clean Room IDs & Titles
why-is-redis-so-fastnow appears asWhy is redis so fast.Screenshots
Testing
Escapekey./activity/<slug>page.Closes #104 Assisted by AI using automatic multi-model routing, primarily Ollama.