Repository navigation
Validate key lengths and avoid overflowing decoded offsets - #445
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 65518-byte key can be written successfully but makes
Getpanic withslice bounds out of range [18:0]. The decoded key length is auint16, so adding the 18-byte entry header wraps before it is used as a slice offset. Longer keys also affect value decoding and the key comparison used byAppend.Convert decoded lengths to
intbefore computing offsets. Reject keys longer than the two-byte length field can represent inSetandAppend, before changing cache state, and document that limit.Tests cover the last length before the overflow, the first overflowing length, and the maximum representable key across
Get,GetWithInfo,Append, and iteration. Both write methods reject 65536-byte keys without replacing an existing colliding entry.Validation on macOS arm64 with Go 1.27.2:
go test -race -count=1 ./...passes.go vet ./..., golangci-lint for new issues, andgit diff --checkpass.