Repository navigation
perf: avoid allocating hashmapStats when stats are disabled - #437
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When StatsEnabled is false (the default configuration), hashmapStats was still allocated for every shard via make(map[uint64]uint32, ...). In setups with many shards and instances, this incurred unnecessary heap allocation and bucket overhead at startup. Only allocate hashmapStats during initNewShard and reset when StatsEnabled is true, and safely guard hashmapStats operations. Fixes allegro#422
Author
|
Closing in favor of earlier community PR #423 to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When StatsEnabled is false (the default configuration), hashmapStats was still being allocated for each cache shard in initNewShard and reset. In configurations with many shards and cache instances, this incurred unnecessary heap allocation and bucket memory overhead at startup.
This change:
Fixes #422