Repository navigation
fix(navigation): a sub-menu never keeps a stored action (mendixlabs/mxcli#1341) - #1082
Merged
Merged
Conversation
) Turning page item 'Work' into sub-menu 'Work' paired the two by caption, and keepStoredMenuAction's sub-menu branch carried the page item's Forms$FormAction onto the sub-menu ("MDL cannot express it"). mx check then failed with CE0548 "Items with subitems cannot have an action themselves." A sub-menu cannot hold an action, so nothing stored is kept on it; the navigation and menu-document writers share the decision. Measured on 11.14.0 with the committed bug-test script: unfixed build -> docker check CE0548; fixed -> 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JAkNou7mZAV7LRE6kGwzDs
…w1cfj # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning page item 'Work' into sub-menu 'Work' paired the two by caption,
and keepStoredMenuAction's sub-menu branch carried the page item's
Forms$FormAction onto the sub-menu ("MDL cannot express it"). mx check then
failed with CE0548 "Items with subitems cannot have an action themselves."
A sub-menu cannot hold an action, so nothing stored is kept on it; the
navigation and menu-document writers share the decision.
Measured on 11.14.0 with the committed bug-test script: unfixed build ->
docker check CE0548; fixed -> 0 errors.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01JAkNou7mZAV7LRE6kGwzDs