Repository navigation
Add languages() to the Starlark lint API (mendixlabs/mxcli#1306) - #1031
Merged
Merged
Conversation
A lint rule had no way to read the enabled project languages: strings() has a row for every stored translation, and a fresh en_US-only app already carries nl_NL texts, so enabling a language changed nothing a rule could see, and a rule calling languages() failed with "undefined: languages". languages() returns one `language` struct (code, is_default, check_completeness) per language enabled in the project settings, read through LintReader.GetProjectSettings like project_security(). It needs no full catalog build; a failed settings read fails the rule rather than answering []. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEhfut5q23z8UtgD762ZPc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lint rule had no way to read the enabled project languages: strings()
has a row for every stored translation, and a fresh en_US-only app already
carries nl_NL texts, so enabling a language changed nothing a rule could
see, and a rule calling languages() failed with "undefined: languages".
languages() returns one
languagestruct (code, is_default,check_completeness) per language enabled in the project settings, read
through LintReader.GetProjectSettings like project_security(). It needs
no full catalog build; a failed settings read fails the rule rather than
answering [].
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01CEhfut5q23z8UtgD762ZPc