Repository navigation
Require zstd support for both Keepa clients - #237
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Keepa clients now request
zstdresponses and install the codec support as a required dependency. JSON queries, raw synchronous responses, and graph-image downloads use the HTTP libraries' native decoding while retaining gzip, deflate, and uncompressed response support.Require Requests >=2.32.5, urllib3[zstd] >=2.7.0, and aiohttp >=3.14.0. Python 3.10–3.13 receive backports.zstd through the urllib3 extra; Python 3.14+ uses compression.zstd. Runtime testing rejected aiohttp 3.13.1 because it fails on concatenated zstd frames; aiohttp 3.14.0 includes that fix. Async graph downloads also now read the complete eight-byte PNG signature before validating it, allowing signatures split across decompressed chunks.
Validation:
2e23c11: 146 passed, three existing expected-failure tests passed, and 98.46% coverage on each. Verified the logs include all 38 compression socket tests and both live zstd assertions. Documentation passed too.Content-Encoding: zstdand successfully decode the response; the token endpoint is free.Compression is part of the library and its normal test suite. The existing Python 3.10/3.14 full-suite jobs run all 38 compression socket tests and the live Keepa zstd negotiation assertions, retain the 85% coverage gate, and gate releases. There is no separate compression CI job. Both clients request zstd by default, and its codec support is a core installation dependency.