Repository navigation
Combined PRs into large update - #87
Open
timothyschoen wants to merge 141 commits into
Open
timothyschoen wants to merge 141 commits into
timothyschoen wants to merge 141 commits into
Conversation
with proxy function for canvas messages and clock for cleanup
…f warnings, clean up buffered tcl/tk images when object is deleted
…addcheckbox`, `_properties_addtextinput` and `_properties_addcolorpicker`
pd-lib-builder has means to install entire directories, so we should probably use them, rather than build our own (and broken) install replacement. Closes: agraef#81
timothyschoen
force-pushed
the
pdlua-combined-prs
branch
from
March 24, 2026 12:11
3a5a1f3 to
3968c17
Compare
timothyschoen
force-pushed
the
pdlua-combined-prs
branch
from
March 24, 2026 13:15
e367023 to
46bbcea
Compare
…ove single argument set_color
add mouse_enter/exit to help
avoid canvas scrollbars for GUI objects in pd vanilla
Contributor
|
@timothyschoen one minor detail i realized when using the luajit version lately: obviously, messages like |
the previous separate coords update does not track Pd's Tcl-side canvas zoom; one-shot create matches draw_line/fill_rect
one-shot create matches updated path/line/rect
instead of minting new id on every create
clock-driven repaints were writing canvas commands immediately, so a save dialog that stops the GUI from reading could fill the blocking socket and hang Pd.
fixes for new pd zoom, avoid excessive gui tag generation
timothyschoen
force-pushed
the
pdlua-combined-prs
branch
from
October 11, 2026 13:49
2dea98f to
5eeeb50
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress to take some work away from @agraef for the next update.
I've merged most of the opened PRs into a new branch, resolving conflicts and adding missing plugdata implementations if needed. It includes:
#84: SVG rendering by @timothyschoen
#82: Makefile improvement by @umlaeute
#80: Clock deprecation fix by @ben-wes
#79: Github actions runner fix by @ben-wes
#77: Property menu support by @charlesneimog
#76: Fix compilation against new Pd version by @ben-wes
#70: Add mouse enter/exit callbacks by @ben-wes
#69: Fix path:close() documentation error by @ben-wes
#66: Make some gfx arguments optional by @ben-wes
#65: Add alignment feature to text drawing by @ben-wes
timothyschoen#7: Fix missing return value by @KottV
timothyschoen#9: Avoid canvas scrollbars for GUI objects in pd vanilla by @ben-wes
timothyschoen#10: Fix pd-0.57 zoom support, fix memory leak, fix freeze caused by save dialog by @ben-wes
On top of that:
Planned:
I'm aware that this is gonna be a big set of changes. To ensure stability, I was hoping to get some assistance with testing from @ben-wes and @charlesneimog, once I get this out of the draft stage.