Repository navigation
fix(agent): pass open_browser in the auth recovery test fixture - #254
Merged
Merged
Conversation
yuval-k
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas failedTest and lintsince a33f11e. #241 addedauth_recovery_tests.rs, which callsrun_sessionwith 10 arguments, and #231 added anopen_browser: boolparameter torun_session. Each passed CI on its own; together they don't compile:This passes
false. The flag only decides whetheroidc::enrolllaunches a browser, so it doesn't change what these tests check, and a test should never open one.The test module is Linux-only (
cfg(all(test, target_os = "linux"))), so the break doesn't show up in a macOS build. It also turnsTest and lintred on every open PR, since PR checks build againstmain.