Repository navigation
Conversation
This was referenced Nov 11, 2026
yuval-k
force-pushed
the
agents/agent-desktop-device-enrollment-update
branch
2 times, most recently
from
November 13, 2026 15:03
afd920c to
b86805a
Compare
yuval-k
marked this pull request as ready for review
November 13, 2026 16:04
yuval-k
force-pushed
the
agents/agent-desktop-device-enrollment-update
branch
from
November 13, 2026 16:16
b86805a to
fcd71a6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of starting a pending enrollment, waiting for user OIDC sign-in and then finish the enrollment, we enroll after the user's OIDC sign-in is complete.
This removes the need to track pending enrollments on the controller: there is no longer a cap of 1,024 pending enrollments, and no in-memory enrollment state, so controller replicas don't need sticky routing.
Changes
GetLoginConfiguration(read-only) andEnrollDevicereplaceBeginEnrollment/CompleteEnrollment. Breaking: upgrade controller and agents together; there is no fallback.0005_enrollment_receipts: retries with the same user and CSR return the original device and certificate, including after a controller restart.Follow-up: #255.