Repository navigation
release: ship orchd with its rootstocks as binaries - #74
Merged
Merged
Conversation
A release now builds orchd, orchd-rootstock-bare and, on macOS, the Apple runtimes for x86_64-linux, aarch64-linux and aarch64-macos, tests them, and attaches one tarball per target. The same build runs on pull requests that touch the workflow or the justfile.
A test that writes a script and execs it races every fork in the parallel test process: a sibling's child can inherit the write fd, and Linux refuses the exec with ETXTBSY. The script is now written under a draft name and copied into place by cp, so this process never holds it open for writing. CI runs every target to the end and uses the Node 24 actions.
adiled
force-pushed
the
release-binaries
branch
from
November 9, 2026 18:38
e08e3ee to
d3bdca0
Compare
A plugin may exit before reading the envelope, closing the pipe under orchd's write. orchd reported the broken pipe instead of the plugin's own reason. The write now lets a closed pipe pass, so the exit status and stderr speak. release.sh keeps orchd-rootstock-bare's version in lockstep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #73, bare is a Zig binary that ships beside orchd. A crates.io install can't bring it along, so a release now has to carry binaries.
x86_64-linux,aarch64-linux,aarch64-macos) the job runsjust testandjust dist, then packsdist/binasorchd-<target>.tar.gz. On macOS that includes orchd-apple, orchd-osx and orchd-osx-init, signed.just installfrom source second.release.shkeeps orchd-rootstock-bare's version in lockstep.Running on Linux turned up two test-side problems and one real bug:
cp. Otherwise a parallel test's fork can inherit the write fd, and Linux refuses the exec with ETXTBSY.fail-fastis off so every target reports.