Repository navigation
Make session persistence and delivery checks reliable - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session writes can overwrite concurrent turns, Node 20 fails despite advertised support, and transcript phrases can satisfy delivery checks without execution. Serialize whole session mutations across local CLI processes, use unique atomic snapshots, surface corrupt/abandoned state, and replace text gates with explicitly enabled host commands and hashed receipts. HTTP adapters now support timeout/cancellation, and check timeouts terminate the child process tree.
Validation: regression coverage includes concurrent instances, duplicate spawns, failure recovery, forged transcript evidence, command failures/timeouts, corrupt state, and HTTP cancellation. Existing mock CLI tests remain. All 22 tests and TypeScript checks pass locally on Node 20 and Node 26. CI covers Node 20, 22, and 24.
Delivery-contract compatibility change: text/bare criteria and missing/empty criteria fail closed; migrate to file artifacts or reviewed command argv arrays with
--run-checks. This remains a model-session MVP; documentation uses source installation and states the tool-execution boundary.