refactor: Settings - #822
Conversation
github-actions
Bot
added
the
🧱 Refactor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1f6a65cfb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <h3 className="text-muted-foreground px-4 text-sm font-medium"> | ||
| {title} | ||
| </h3> |
There was a problem hiding this comment.
When the overview or devices screen renders, PageTitle provides the page's <h1>, but every immediate section produced here starts at <h3>, leaving no <h2> and giving screen-reader heading navigation an incorrect hierarchy. Render these group titles as <h2> elements instead.
AGENTS.md reference: AGENTS.md:L55-L56
Useful? React with 👍 / 👎.
|
|
||
| return ( | ||
| <AutoForm | ||
| className="flex flex-col gap-3 space-y-0 px-4 py-4" |
There was a problem hiding this comment.
This form combines gap-3 with space-y-0 on the same element to override Form's default space-y-8, contrary to the repository's explicit gap-only spacing convention. Provide a gap-based way to suppress the shared form spacing rather than mixing both spacing systems here.
AGENTS.md reference: AGENTS.md:L68-L68
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?