Repository navigation
Preserve Apple account credentials after transient authentication failures - #884
Open
zunda-pixel wants to merge 1 commit into
Open
zunda-pixel wants to merge 1 commit into
zunda-pixel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Xcodes during a temporary network outage can cause session validation to fail, trigger an automatic sign-in, and delete the saved account name and Keychain password when that request also fails. Subsequent launches then cannot restore the saved account.
Only attempt automatic sign-in when session validation reports an invalid session or an unauthorized response. Preserve saved credentials when authentication fails so the user can retry, and avoid presenting cancellation as an authentication error. Explicit sign-out continues to remove saved credentials.