Repository navigation
test: bring public's suites up to the v0.133.0 plugin - #293
Conversation
A promotion replaces plugins/memhub/ and install.sh only, so public's tests/ stayed at 0.124.0 while the plugin moved to 0.133.0. Twelve suites failed guard and probe-tests on #292, each on an intentional internal change. The twelve suites are internal's at 5403278e (the promoted commit), with memhub-staging rewritten to memhub. The README's installer paragraph now describes the installer this release ships (auto-update, fork agent, the repository allowlist with /memhub:repos, the companion prompt). No file under plugins/ changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🧠 Session context1 session behind this pull request. Team rules that fired while building this
Effort Sessions
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83497af116
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "tag_memory", "copy_to_agent_brain", "delete_memory", "create_agent_brain", | ||
| "share_agent_brain", "list_agent_brain_access", "list_brain_folders", | ||
| "move_brain_to_folder", "list_sessions", "add_memory", "import_conversation", | ||
| "move_brain_to_folder", "list_sessions", "import_conversation", |
There was a problem hiding this comment.
When a shipped script or skill mentions add_memory outside allowed-tools, deleting it from _MCP_SURFACE does not catch the stale reference: test_shipped_files_name_no_removed_mcp_tool builds its regex exclusively from _REMOVED_MCP, where add_memory was not added. This leaves the newly retired API without the regression protection described above and can allow instructions that teach agents a server-refused call.
Useful? React with 👍 / 👎.
| gh = bin_dir / "gh" | ||
| gh.write_text(f"#!{sys.executable}\n" + _FAKE_GH, encoding="utf-8") | ||
| gh.chmod(0o755) |
There was a problem hiding this comment.
On Windows, an extensionless file with a Unix shebang is not a runnable gh command discovered through PATH, and chmod does not change that. Consequently the newly added batch tests either report gh not found or invoke an unrelated installed GitHub CLI instead of this fixture, breaking tests/run_all.py on a platform that the test runner explicitly supports; use a platform-appropriate wrapper or skip this fixture when it cannot be executed.
Useful? React with 👍 / 👎.
With the 0.133.0 plugin, check-plugin.sh's bare-Python and MCP-SDK legs run past guard's 10-minute limit (cancelled at 10m16s on #292, #293 and this PR), so guard never reports. promote.yml on internal runs the same two legs under 20 minutes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A promotion replaces
plugins/memhub/andinstall.shonly, so public'stests/stayed at 0.124.0 while the plugin moved to 0.133.0. Twelve suites failedguardandprobe-testson #292, each on an intentional internal change.The twelve suites (
claude_hook_guard,codex_rulebook_context,cursor_capture,documentation,find_sessions,harness_stop,mine_sessions,pr_link,pr_work_type,rulebook_hook,rulebook_repo_of_call,starter_rulebook) are internal's at 5403278e (the promoted commit), withmemhub-stagingrewritten tomemhub. The root README's installer paragraph now describes the installer this release ships: auto-update, fork agent, the repository allowlist with/memhub:repos, and the companion prompt. No file underplugins/changes.Locally, against the identical export: run_all 72/72, version parity and test registration pass.
Stacked on #292. Merge this into
promote/memhub-v0.133.0first (as #286 was for #285).🤖 Generated with Claude Code