Repository navigation
install.sh: a hung cursor-agent no longer stalls the installer (ENG-1237) - #291
Merged
Merged
Conversation
Same change as agent-plugins-internal#200, so the public curl installer stops hanging at the Cursor step until the next promotion overwrites it. `cursor-agent plugin marketplace add` (and `update`) waits on Cursor's backend with no timeout of its own, so `curl ... | sh` never reached sign-in. Now a known marketplace skips `add`, every cursor-agent call runs under a `with_timeout` helper (python3; macOS has no `timeout`), and a failed add or refresh prints a warning and continues. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
felix-xtrace
deployed
to
production-plugin-release
October 13, 2026 02:32 — with
GitHub Actions
Active
🧠 Session context1 session behind this pull request. Team rules that fired while building this
Effort Sessions
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
felix-xtrace
had a problem deploying
to
production-plugin-release
October 13, 2026 02:37 — with
GitHub Actions
Failure
felix-xtrace
deployed
to
production-plugin-release
October 13, 2026 02:37 — with
GitHub Actions
Active
felix-xtrace
deployed
to
production-plugin-release
October 13, 2026 02:37 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of XTraceAI/agent-plugins-internal#200 (merged). Public
install.shonmainwas byte-identical to internal's pre-fix copy, so this is the same patch; after it, the file matches internalmainexactly. The next promotion will overwrite it with the same content.Problem
curl -fsSL .../install.sh | shhangs forever at the Cursor step:cursor-agent plugin marketplace add(andmarketplace update) waits on Cursor's backend with no timeout of its own. Reproduced on macOS with cursor-agent2026.09.15-d2fe57e: still waiting after 45s+ (one open TLS connection, no git child), even thoughxtrace-pluginswas already registered. Because the step never returns, the installer never reaches sign-in.Fix
marketplace addwhencursor-agent plugin marketplace listalready shows$CURSOR_MKT.cursor-agentcall under a newwith_timeouthelper (python3, which the installer already requires; macOS has notimeout). Exit 124 on timeout, as GNU timeout does. The child's stdin is/dev/null, so it can't read the rest of acurl | shscript.Testing
sh -n install.shdiffagainst internalmain'sinstall.sh: identical.with_timeouthelper in isolation: a hanging command exits 124, a passing one exits 0, a failing one passes its exit code through.cursor-agentruns are in the internal PR.🤖 Generated with Claude Code