Skip to content

Camera and Controller Research/Recommendation - #33

Open
Gkong5020 wants to merge 14 commits into
mainfrom
docs/camera-controller-handoff-gianna
Open

Gkong5020 wants to merge 14 commits into
mainfrom
docs/camera-controller-handoff-gianna

Conversation

@Gkong5020

Copy link
Copy Markdown

Camera Research

Summary

  • Added a README to summarize the main camera system design document
  • Included older, initial research documents
  • Contains detailed system design prototype with initial testing and camera recommendations

Controller research

Summary

  • Compared two 3D controllers that could potentially work with the robot
  • Weighed the pros and cons of each controller and decided on a main recommendation and fallback
  • Mapped controls to each controller

@Gkong5020
Gkong5020 requested a review from yassinsolim as a code owner October 3, 2026 19:07
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9ee67dfd-ae7e-4382-a3a7-4db454381214
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yassinsolim yassinsolim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good research, Gianna: the camera design, the Orbbec Gemini 2 recommendation, the controller comparison and the input mapping are all useful. A few points before it can merge:

  1. docs/camera-research/README.md line 30 says the latency should "remain consistently >30-50ms". It should be below 30 to 50 ms.
  2. Line 11 links to doctor_camera_system_design.md on your branch, which breaks after the merge. Please use a relative link.
  3. Spelling: Electrial, seperate, attatched, exaxtly, ergonimic and qual-core.
  4. Please add the measured delay. Run the doctor-view feed from #36 with a USB webcam for five minutes, at 1080p and 30 fps if the camera supports it, and report the average, minimum and maximum delay and the jitter, with a stopwatch cross-check. Note which numbers depend on the webcam rather than the Gemini 2.

Then re-request a review.

@yassinsolim yassinsolim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gianna. Points 1 to 3 are fixed: the latency target, the relative link and the spelling. One new typo: doctor_camera_system_design.md has a double space in "Directly attached to arm".

Point 4 is still open. Add the measured delay from the doctor-view feed, which is on main now (camera:=true). Then re-request a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants