Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yassinsolim
left a comment
There was a problem hiding this comment.
Good research, Gianna: the camera design, the Orbbec Gemini 2 recommendation, the controller comparison and the input mapping are all useful. A few points before it can merge:
docs/camera-research/README.mdline 30 says the latency should "remain consistently >30-50ms". It should be below 30 to 50 ms.- Line 11 links to
doctor_camera_system_design.mdon your branch, which breaks after the merge. Please use a relative link. - Spelling: Electrial, seperate, attatched, exaxtly, ergonimic and qual-core.
- Please add the measured delay. Run the doctor-view feed from #36 with a USB webcam for five minutes, at 1080p and 30 fps if the camera supports it, and report the average, minimum and maximum delay and the jitter, with a stopwatch cross-check. Note which numbers depend on the webcam rather than the Gemini 2.
Then re-request a review.
yassinsolim
left a comment
There was a problem hiding this comment.
Thanks, Gianna. Points 1 to 3 are fixed: the latency target, the relative link and the spelling. One new typo: doctor_camera_system_design.md has a double space in "Directly attached to arm".
Point 4 is still open. Add the measured delay from the doctor-view feed, which is on main now (camera:=true). Then re-request a review.
Camera Research
Summary
Controller research
Summary