Repository navigation
Explain detector and archive processing steps - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some detector and archive comments opened on dense implementation detail before saying what the code is for. They're rewritten to introduce the quantities, walk through the operation, and then explain the result. Short comments stay short, and the spelling is American. Comments on the matched-filter cell width and row-sum storage didn't match the implementation, so those are corrected.
Frozen evidence, generated tables, quoted source text, and vendored code are untouched. Python syntax trees and C/CUDA tokens were compared before and after, and the executable logic is unchanged.
3,668 CPU tests passed, 74 were skipped, and 111 CUDA-marked tests were deselected. The two extra GPU-only tests in test_reference_pfb_gpu.py were excluded explicitly, and GPU access stayed disabled. Ruff, the generated FFT-table consistency check, the documentation specifications, the C header check, and the CPU reference build and run all passed.