Conversation
florianreuth
requested changes
Sep 22, 2026
florianreuth
left a comment
florianreuth
left a comment
Member
There was a problem hiding this comment.
Shouldn't this go into the 1.19.3->1.19.4 protocol then?
Contributor
Author
|
I'm not sure, all versions between 1.11 and 1.19.4 use the potion's color (which we can just keep passing on), while 1.10 wants the registry id. Unless you mean saving the id there for 1.10 to use down the line, while leaving the other versions untouched? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes potion splash colors in 1.9 and 1.10 on 1.19.4+ servers
Color references:
Not sure if a better solution would be to downsample/find nearest color. I tried with some simple rgb distance matching and it would heavily favor the gray colors. Would be cool to downsample CustomPotionColor though